[26.04_linux-nvidia-bos] watchdog: sbsa_gwdt: add early_enable module parameter - #558
Open
kbutala-nv wants to merge 1 commit into
Open
[26.04_linux-nvidia-bos] watchdog: sbsa_gwdt: add early_enable module parameter#558kbutala-nv wants to merge 1 commit into
kbutala-nv wants to merge 1 commit into
Conversation
Collaborator
BaseOS Kernel ReviewWarning
|
Contributor
PR Validation ReportPatchscan ✅ No Missing FixesAll cherry-picked commits checked — no missing upstream fixes found. PR Lint ❌ Errors foundDetailsChecking 1 commits...
Cherry-pick digest:
┌──────────────┬──────────────────────────────────────────────────────────────────┬────────────┬─────────┬───────────────────────────┐
│ Local │ Referenced upstream / Patch subject │ Patch-ID │ Subject │ SoB chain │
├──────────────┼──────────────────────────────────────────────────────────────────┼────────────┼─────────┼───────────────────────────┤
│ f92bed6ee130 │ [SAUCE] watchdog: sbsa_gwdt: add early_enable module parameter │ N/A │ N/A │ wang, linux, kbutala │
└──────────────┴──────────────────────────────────────────────────────────────────┴────────────┴─────────┴───────────────────────────┘
Lint results:
E: f92bed6ee130 ("watchdog: sbsa_gwdt: add early_enable module param"): not SAUCE/UBUNTU/Revert but has no upstream reference trailer (cherry picked from commit ... or backported from ...)
PR metadata:
E: PR targets 26.04_linux-nvidia-bos but body has no https://bugs.launchpad.net/... link
|
kbutala-nv
force-pushed
the
sbsa-watchdog-bos
branch
from
September 1, 2026 09:16
e315911 to
6b2861b
Compare
On SBSA platforms using standard UEFI firmware (such as EDK II), the watchdog timer is often enabled during early boot stages but explicitly disabled by the firmware before handing over control to the OS (e.g., during ExitBootServices). This is done to prevent unintended resets while the OS is loading, assuming the OS watchdog driver will take over. However, this leaves a protection gap. If the system hangs between the firmware handover and the userspace watchdog daemon startup, the hardware watchdog will not fire to recover the system. For safety-critical systems that require continuous hardware watchdog protection from the earliest possible moment, this gap is problematic. Add an 'early_enable' module parameter to allow the kernel driver to re-enable the watchdog immediately during probe if it was left disabled by the firmware. By setting the WDOG_HW_RUNNING status bit, the watchdog core is instructed that the hardware is active. As a result, the core's pre-userspace handler (controlled by 'handle_boot_enabled') will automatically issue periodic keepalives until userspace opens the device. This bridges the protection gap seamlessly without requiring firmware modifications and without risking unintended resets during kernel boot. The parameter defaults to false to preserve the traditional behavior. Signed-off-by: Zexin Wang <[email protected]> Link: https://patch.msgid.link/[email protected] Signed-off-by: Guenter Roeck <[email protected]> (backported from commit 11f93e639d51 groeck/linux-staging.git) Signed-off-by: Kaushal Rajeev Butala <[email protected]>
kbutala-nv
force-pushed
the
sbsa-watchdog-bos
branch
from
September 1, 2026 11:27
6b2861b to
f92bed6
Compare
kbutala-nv
changed the title
Collaborator
|
Is this patch needed for Vera too @kbutala-nv ? |
Collaborator
|
Same comment as in PR 557, please pick with -xs and append "linux-next" after the SHA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains backport of change https://patch.msgid.link/[email protected]
We need this patch to support newer firmware revisions.
(backported from commit 11f93e639d51 groeck/linux-staging.git)