Repository navigation
Align trust docs with shipped crypto and desktop reality - #41
Conversation
Document what is actually implemented (AES file seal, Node sidecar, workspace-secret key storage, manual desktop CI, 8-person demo seed) versus aspirational targets (OS keychain, SQLCipher/Rusqlite, signed auto-update, IPC-only topology) so a public adversarial review matches the code. Co-authored-by: Damon <[email protected]>
Co-authored-by: Damon <[email protected]>
|
Warning Review limit reached
Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe documentation now reflects the shipped browser/API and Tauri/Node stack, workspace encryption, encrypted AI keys, backup behavior, delivery workflow, demo data, and shipped versus unshipped security capabilities. ChangesLocal stack documentation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Summary
Adversarial review found architecture / delivery docs claiming OS keychain, SQLCipher/Rusqlite-first, IPC-only topology, 12-person seed, and desktop CI on every
mainmerge — none of which match the shipped code.This PR rewrites the honesty layer in:
docs/architecture/TRUST_MODEL.mddocs/architecture/LOCAL_STACK.mddocs/architecture/SYSTEM.mddocs/DELIVERY.mddocs/CORE_LOOP_EVAL.mdShipped vs target is now explicit so a public adversarial review matches the code.
Test plan
Summary by CodeRabbit