Skip to content

feat: access RE::BSTSmartPointer<BSScript::Object> without using global var #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AtomCrafty merged 3 commits into from
Sep 18, 2026
Merged

feat: access RE::BSTSmartPointer<BSScript::Object> without using global var #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d24be79
feat: access `RE::BSTSmartPointer<BSScript::Object>` without using gl…
shad0wshayd3 Sep 18, 2026
f2805ae
formatting: match project formatting
shad0wshayd3 Sep 18, 2026
6c7b8de
feat: move `ScriptObject::FromForm` call to `UpdateSettings`
shad0wshayd3 Sep 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/Config/Papyrus.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,24 @@ namespace QuickLoot::Config
return;
};

MCMScript = Util::ScriptObject::FromForm(quest, "QuickLootIEMCM");
if (!MCMScript.IsValid()) {
logger::info("Unable to locate MCM script on form");
return;
};
MCMQuest = quest;

logger::info("MCM pointer set successfully");
logger::info("MCM quest pointer set successfully");

UserSettings::Update();
};

void Papyrus::UpdateVariables(RE::StaticFunctionTag*)
{
auto MCMScript = Util::ScriptObject::FromForm(MCMQuest, "QuickLootIEMCM");
if (!MCMScript.IsValid()) {
logger::error("Unable to locate MCM script on form");
return;
}

PROFILE_SCOPE;

#define LoadSettingsVar(name, ...) LoadSetting(name, #name, __VA_ARGS__)
#define LoadSettingsVar(name, ...) LoadSetting(MCMScript, name, #name, __VA_ARGS__)

// General > Behavior Settings
LoadSettingsVar(QLIE_ShowInCombat, true);
Expand Down
6 changes: 3 additions & 3 deletions src/Config/Papyrus.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

namespace QuickLoot::Config
{
static Util::ScriptObject MCMScript{};
static RE::TESQuest* MCMQuest{ nullptr };

inline bool QLIE_ShowInCombat;
inline bool QLIE_ShowWhenEmpty;
Expand Down Expand Up @@ -140,9 +140,9 @@ namespace QuickLoot::Config
}

template <typename T>
static void LoadSetting(T& variable, const std::string& propertyName, const T& defaultValue)
static void LoadSetting(Util::ScriptObject& mcmscript, T& variable, const std::string& propertyName, const T& defaultValue)
{
const auto* prop = MCMScript.GetProperty(propertyName);
const auto* prop = mcmscript.GetProperty(propertyName);

if (!prop) {
variable = defaultValue;
Expand Down