feat: access RE::BSTSmartPointer<BSScript::Object> without using global var - #113
Merged
AtomCrafty merged 3 commits intoSep 18, 2026
Merged
Conversation
AtomCrafty
requested changes
Sep 18, 2026
| template <typename T> | ||
| static void LoadSetting(T& variable, const std::string& propertyName, const T& defaultValue) | ||
| { | ||
| auto MCMScript = Util::ScriptObject::FromForm(MCMQuest, "QuickLootIEMCM"); |
Collaborator
There was a problem hiding this comment.
We should just do this once in UpdateVariables and pass the script to LoadSetting. It's currently retrieving the script object again and again for every single variable we want to read.
Collaborator
|
@shad0wshayd3 lmk if you want to do that yourself or if I should do it. |
Collaborator
|
Thanks! Now that I look at this again I wonder whether we even need |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Papyrus::SetFrameworkQuestto store anRE::TESQuestpointer rather than anRE:BSTSmartPointer<RE:BSScript::Object>LoadSettings<T>to callUtil::ScriptObject::FromFormto fetch a temporaryRE::BSTSmartPointer<RE::BSScript::Object>using the storedRE::TESQuestpointer