Repository navigation
Add Classroom browser E2E and accessibility coverage - #308
Merged
Merged
Conversation
This was referenced Oct 6, 2026
MajorIncident
marked this pull request as ready for review
October 6, 2026 14:32
This was referenced Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Program / issues
mainat merged Protect Classroom Case Study delivery #307 (09f034f1f1776a3aaf92be7dec86b902549c8eb9)feature/classroom-browser-e2eCloses #296
Closes #279
Outcome
Adds one deterministic real-browser quality layer for Standalone, Student, and Instructor behavior without depending on Vercel feature previews or production credentials.
The final browser matrix covers:
Browser execution contract
scripts/serve-browser-tests.mjsprovides a deterministic local HTTP/API fixture.Required CI decision
Browser regression is required, not advisory.
The existing branch-protected
testsstatus now:npm run quality;npm run test:browser.This preserves the existing protected status context rather than requiring a repository-rules migration. The separate
Browser E2E (manual)workflow remains available only for focused diagnostics.Final documented head:
eba5f5139195f9df9de54f25093ed80f5b01e064.Validation on the final head:
tests/ CI: green, including 22 browser tests passed / 6 intentional project-scoped skips / 0 failed;main: 101 ahead / 0 behind;Product fixes discovered by real-browser coverage
The suite found and protected fixes for:
aria-readonly;Guardrails
Cold restart / next product direction
Read
docs/classroom-workstream.md,docs/classroom-roadmap.md, anddocs/testing-guidelines.md.After this PR:
#313 should build on #312 rather than bypassing the live-class/team-management substrate.