Skip to content

fix(tvk,tvs): stop re-applying earlier input at later periods and time steps - #3159

Open
mjreno wants to merge 7 commits into
MODFLOW-ORG:developfrom
mjreno:fix_tv_stamp
Open

mjreno wants to merge 7 commits into
MODFLOW-ORG:developfrom
mjreno:fix_tv_stamp

Conversation

@mjreno

@mjreno mjreno commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Problem: Since 6.8.0, TVK and TVS re-applied every earlier value at each later PERIOD block, and at every time step when a time-series file was given. With NPF K22OVERK/K33OVERK, an earlier ratio was applied to a later K, changing K22/K33 (6.7.0 did not). Each re-application also re-listed the input and flagged cells as changed.

Solution: The keystring loader stamps each value with the input step (an ATS retry keeps the same step) and how it was written: given in a PERIOD block, or by a time series. As in 6.7.0, TVK and TVS apply block values in prepare_time_step and time-series values in prepare_solve, K first in each, whether or not a time-series file is given. Packages read the stamps, the read states and the static-block time-series links through one view; SFR, LAK and MAW now use it for their links.

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Added new test or modified an existing test
  • Ran ruff on new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.
  • Formatted new and modified Fortran source files with fprettify
  • Added doxygen comments to new and modified procedures
  • Updated meson files, makefiles, and Visual Studio project files for new source files
  • Updated definition files
  • Added a release note to doc/ReleaseNotes/items/ with a plain-language description of the bug fix, change, or feature; required for changes that may affect users
  • Updated input and output guide
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@mjreno mjreno changed the title fix(tv): apply input only when it is written fix(tvk,tvs): stop re-applying earlier input at later periods and time steps Nov 13, 2026
@mjreno mjreno added this to the 6.8.3 milestone Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant