Repository navigation
Conversation
…th the invalid reduced node
mjreno
marked this pull request as draft
November 16, 2026 13:08
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Full-grid time-array series for grid array input
Adds time-array series (
TAS) support for grid array (READARRAYGRID) period input, and integrates theIDMgrid array loader with it. Branched from #3159 (TVK/TVSwrite stamps).Grid array loader. The loader has two modes. The package dfn fixes the mode, not the user:
MAXBOUND(optional or required), e.g.CHDG, WELG, DRNG, RIVG, GHBG. ThePERIODblock defines boundary cells, and the package reads them as a list (NODEULIST, NBOUND).MAXBOUND. ThePERIODblock changes values on a fixed grid, and the package reads arrays by user node.The loader is a shared base type with one type per mode.
Persistence rules, compressed:
Persistence rules, full grid:
DNODATAand inactive cells leave it unchanged.Time-array series:
TASarrays cover the full grid, and a linked array updates each time step until it's given again.DNODATAvalue at a boundary cell is an error.DNODATAvalue leaves the cell unchanged.utl-tas.dfn: the consuming package decides the array shape.READARRAYGRIDpackages always read full-grid arrays, and the mode follows the package dfn, so it isn't a user choice.DNODATAisn't scaled: neitherFACTORnorSFACscales it.TAScode;RCHA/EVTA/SPCAresults unchanged).TVKG:K, used locally to develop and test full-grid mode;K22/K33ratios can't be read fromNetCDF. Currently included in this PR, but it may be removed before merging if no use cases are apparent.Also:
NetCDFexport of full-grid input writes the stored values each period; grid arrays linked to a series are written as fill.SWI TVGpackage integration and testing tbd locally.Checklist of items for pull request
ruffon new and modified python scripts in .doc, autotests, doc, distribution, pymake, and utils subdirectories.fprettifyFor additional information see instructions for contributing and instructions for developing.