Skip to content

fix(dfns): pin MF6 DFNs with corrected PRINT_FORMAT records #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpbonelli merged 1 commit into from
Nov 11, 2026
Merged

fix(dfns): pin MF6 DFNs with corrected PRINT_FORMAT records #414

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
uses: actions/checkout@v4
with:
repository: MODFLOW-ORG/modflow6
ref: "6.8.2"
ref: "65278c938a0c6e742b52fa7398b35a9aea6c0752"
path: modflow6

- name: Setup uv
Expand Down
10 changes: 4 additions & 6 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/chf-oc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,25 +99,23 @@
"columns": {
"type": "integer",
"longname": "number of columns",
"description": "number of columns for writing data.",
"optional": true
"description": "number of columns for writing data."
},
"width": {
"type": "integer",
"longname": "width for each number",
"description": "width for writing each number.",
"optional": true
"description": "width for writing each number."
},
"digits": {
"type": "integer",
"longname": "number of digits",
"description": "number of digits to use for writing a number.",
"optional": true
"description": "number of digits to use for writing a number."
},
"format": {
"type": "string",
"longname": "write format",
"description": "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.",
"optional": true,
"tagged": false
}
}
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/chf-oc.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,24 +89,22 @@ type = "record"
type = "integer"
longname = "number of columns"
description = "number of columns for writing data."
optional = true

[blocks.options.fields.qoutflowprintrecord.fields.formatrecord.fields.width]
type = "integer"
longname = "width for each number"
description = "width for writing each number."
optional = true

[blocks.options.fields.qoutflowprintrecord.fields.formatrecord.fields.digits]
type = "integer"
longname = "number of digits"
description = "number of digits to use for writing a number."
optional = true

[blocks.options.fields.qoutflowprintrecord.fields.formatrecord.fields.format]
type = "string"
longname = "write format"
description = "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC."
optional = true
tagged = false

[blocks.period.fields.stress_period_data]
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/chf-oc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,21 +86,19 @@ blocks:
type: integer
longname: number of columns
description: number of columns for writing data.
optional: true
width:
type: integer
longname: width for each number
description: width for writing each number.
optional: true
digits:
type: integer
longname: number of digits
description: number of digits to use for writing a number.
optional: true
format:
type: string
longname: write format
description: write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.
optional: true
tagged: false
period:
fields:
Expand Down
10 changes: 4 additions & 6 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-oc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,25 +81,23 @@
"columns": {
"type": "integer",
"longname": "number of columns",
"description": "number of columns for writing data.",
"optional": true
"description": "number of columns for writing data."
},
"width": {
"type": "integer",
"longname": "width for each number",
"description": "width for writing each number.",
"optional": true
"description": "width for writing each number."
},
"digits": {
"type": "integer",
"longname": "number of digits",
"description": "number of digits to use for writing a number.",
"optional": true
"description": "number of digits to use for writing a number."
},
"format": {
"type": "string",
"longname": "write format",
"description": "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.",
"optional": true,
"tagged": false
}
}
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-oc.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,24 +73,22 @@ type = "record"
type = "integer"
longname = "number of columns"
description = "number of columns for writing data."
optional = true

[blocks.options.fields.temperatureprintrecord.fields.formatrecord.fields.width]
type = "integer"
longname = "width for each number"
description = "width for writing each number."
optional = true

[blocks.options.fields.temperatureprintrecord.fields.formatrecord.fields.digits]
type = "integer"
longname = "number of digits"
description = "number of digits to use for writing a number."
optional = true

[blocks.options.fields.temperatureprintrecord.fields.formatrecord.fields.format]
type = "string"
longname = "write format"
description = "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC."
optional = true
tagged = false

[blocks.period.fields.stress_period_data]
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwe-oc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,19 @@ blocks:
type: integer
longname: number of columns
description: number of columns for writing data.
optional: true
width:
type: integer
longname: width for each number
description: width for writing each number.
optional: true
digits:
type: integer
longname: number of digits
description: number of digits to use for writing a number.
optional: true
format:
type: string
longname: write format
description: write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.
optional: true
tagged: false
period:
fields:
Expand Down
10 changes: 4 additions & 6 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-oc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,25 +81,23 @@
"columns": {
"type": "integer",
"longname": "number of columns",
"description": "number of columns for writing data.",
"optional": true
"description": "number of columns for writing data."
},
"width": {
"type": "integer",
"longname": "width for each number",
"description": "width for writing each number.",
"optional": true
"description": "width for writing each number."
},
"digits": {
"type": "integer",
"longname": "number of digits",
"description": "number of digits to use for writing a number.",
"optional": true
"description": "number of digits to use for writing a number."
},
"format": {
"type": "string",
"longname": "write format",
"description": "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.",
"optional": true,
"tagged": false
}
}
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-oc.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,24 +73,22 @@ type = "record"
type = "integer"
longname = "number of columns"
description = "number of columns for writing data."
optional = true

[blocks.options.fields.headprintrecord.fields.formatrecord.fields.width]
type = "integer"
longname = "width for each number"
description = "width for writing each number."
optional = true

[blocks.options.fields.headprintrecord.fields.formatrecord.fields.digits]
type = "integer"
longname = "number of digits"
description = "number of digits to use for writing a number."
optional = true

[blocks.options.fields.headprintrecord.fields.formatrecord.fields.format]
type = "string"
longname = "write format"
description = "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC."
optional = true
tagged = false

[blocks.period.fields.stress_period_data]
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwf-oc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,21 +72,19 @@ blocks:
type: integer
longname: number of columns
description: number of columns for writing data.
optional: true
width:
type: integer
longname: width for each number
description: width for writing each number.
optional: true
digits:
type: integer
longname: number of digits
description: number of digits to use for writing a number.
optional: true
format:
type: string
longname: write format
description: write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.
optional: true
tagged: false
period:
fields:
Expand Down
10 changes: 4 additions & 6 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwt-ist.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,25 +111,23 @@
"columns": {
"type": "integer",
"longname": "number of columns",
"description": "number of columns for writing data.",
"optional": true
"description": "number of columns for writing data."
},
"width": {
"type": "integer",
"longname": "width for each number",
"description": "width for writing each number.",
"optional": true
"description": "width for writing each number."
},
"digits": {
"type": "integer",
"longname": "number of digits",
"description": "number of digits to use for writing a number.",
"optional": true
"description": "number of digits to use for writing a number."
},
"format": {
"type": "string",
"longname": "write format",
"description": "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.",
"optional": true,
"tagged": false
}
}
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwt-ist.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,24 +103,22 @@ type = "record"
type = "integer"
longname = "number of columns"
description = "number of columns for writing data."
optional = true

[blocks.options.fields.cimprintrecord.fields.formatrecord.fields.width]
type = "integer"
longname = "width for each number"
description = "width for writing each number."
optional = true

[blocks.options.fields.cimprintrecord.fields.formatrecord.fields.digits]
type = "integer"
longname = "number of digits"
description = "number of digits to use for writing a number."
optional = true

[blocks.options.fields.cimprintrecord.fields.formatrecord.fields.format]
type = "string"
longname = "write format"
description = "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC."
optional = true
tagged = false

[blocks.options.fields.sorbate_filerecord]
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwt-ist.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,21 +104,19 @@ blocks:
type: integer
longname: number of columns
description: number of columns for writing data.
optional: true
width:
type: integer
longname: width for each number
description: width for writing each number.
optional: true
digits:
type: integer
longname: number of digits
description: number of digits to use for writing a number.
optional: true
format:
type: string
longname: write format
description: write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.
optional: true
tagged: false
sorbate_filerecord:
type: record
Expand Down
10 changes: 4 additions & 6 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwt-oc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,25 +81,23 @@
"columns": {
"type": "integer",
"longname": "number of columns",
"description": "number of columns for writing data.",
"optional": true
"description": "number of columns for writing data."
},
"width": {
"type": "integer",
"longname": "width for each number",
"description": "width for writing each number.",
"optional": true
"description": "width for writing each number."
},
"digits": {
"type": "integer",
"longname": "number of digits",
"description": "number of digits to use for writing a number.",
"optional": true
"description": "number of digits to use for writing a number."
},
"format": {
"type": "string",
"longname": "write format",
"description": "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC.",
"optional": true,
"tagged": false
}
}
Expand Down
4 changes: 1 addition & 3 deletions autotest/dfns/__snapshots__/v2.0.0.dev2/gwt-oc.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,24 +73,22 @@ type = "record"
type = "integer"
longname = "number of columns"
description = "number of columns for writing data."
optional = true

[blocks.options.fields.concentrationprintrecord.fields.formatrecord.fields.width]
type = "integer"
longname = "width for each number"
description = "width for writing each number."
optional = true

[blocks.options.fields.concentrationprintrecord.fields.formatrecord.fields.digits]
type = "integer"
longname = "number of digits"
description = "number of digits to use for writing a number."
optional = true

[blocks.options.fields.concentrationprintrecord.fields.formatrecord.fields.format]
type = "string"
longname = "write format"
description = "write format can be EXPONENTIAL, FIXED, GENERAL, or SCIENTIFIC."
optional = true
tagged = false

[blocks.period.fields.stress_period_data]
Expand Down
Loading
Loading