Repository navigation
fix(dfns): pin MF6 DFNs with corrected PRINT_FORMAT records - #414
Merged
Merged
Conversation
MODFLOW-ORG/modflow6#3129 fixed formatrecord's optional flags in the DFNs: columns, width and digits are required, and format is optional. MF6 now also rejects a partial record like COLUMNS 2 WIDTH 16, which it used to run and ignore. * pin the MF6 DFNs to 65278c93, the merge commit. Since 6.8.2 the only DFN changes are these six records, in chf-oc, gwe-oc, gwf-oc, gwt-oc, olf-oc and gwt-ist * regenerate the dev2 and dev3 snapshots, where only the optional flags change * test the flags after migration, and the rendered syntax * say in the spec that LAK and MAW observation connection keys are stricter than MF6 Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
accommodate MODFLOW-ORG/modflow6#3129