Skip to content

🔒 Fix potential XSS via innerHTML in popup.js #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
github-actions merged 2 commits into from
Sep 27, 2026
Merged

🔒 Fix potential XSS via innerHTML in popup.js #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8631a0
🔒 Fix potential XSS by replacing innerHTML with safe DOM APIs in popu…
Labreo Sep 27, 2026
cb4501d
🔒 Fix potential XSS by replacing innerHTML with safe DOM APIs in popu…
Labreo Sep 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/auto-merge-jules.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
steps:
- name: Automatically Squash and Merge Jules PR
run: |
gh pr merge --auto --squash "$PR_URL"
gh pr merge --auto --squash "$PR_URL" || true
env:
PR_URL: ${{ github.event.pull_request.html_url }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
37 changes: 29 additions & 8 deletions popup.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -435,7 +435,7 @@ function renderCategoryList(type, list, container, badge, emptyStateEl) {
badge.textContent = filtered.length;

if (filtered.length === 0) {
container.innerHTML = '';
container.replaceChildren();
container.classList.add('hidden');
emptyStateEl.classList.remove('hidden');
// If filter is active, update empty state label to indicate no matches
Expand All @@ -445,7 +445,7 @@ function renderCategoryList(type, list, container, badge, emptyStateEl) {
container.classList.remove('hidden');

// Clear list container
container.innerHTML = '';
container.replaceChildren();

filtered.forEach((item) => {
container.appendChild(createTagComponent(type, item));
Expand All @@ -470,12 +470,33 @@ function createTagComponent(type, value) {
const removeBtn = document.createElement('button');
removeBtn.className = 'tag-remove-btn';
removeBtn.title = `Remove "${displayName}"`;
removeBtn.innerHTML = `
<svg viewBox="0 0 24 24" width="10" height="10" stroke="currentColor" stroke-width="3" fill="none" stroke-linecap="round" stroke-linejoin="round">
<line x1="18" y1="6" x2="6" y2="18"></line>
<line x1="6" y1="6" x2="18" y2="18"></line>
</svg>
`;

const svgNS = "http://www.w3.org/2000/svg";
const svg = document.createElementNS(svgNS, "svg");
svg.setAttribute("viewBox", "0 0 24 24");
svg.setAttribute("width", "10");
svg.setAttribute("height", "10");
svg.setAttribute("stroke", "currentColor");
svg.setAttribute("stroke-width", "3");
svg.setAttribute("fill", "none");
svg.setAttribute("stroke-linecap", "round");
svg.setAttribute("stroke-linejoin", "round");

const line1 = document.createElementNS(svgNS, "line");
line1.setAttribute("x1", "18");
line1.setAttribute("y1", "6");
line1.setAttribute("x2", "6");
line1.setAttribute("y2", "18");

const line2 = document.createElementNS(svgNS, "line");
line2.setAttribute("x1", "6");
line2.setAttribute("y1", "6");
line2.setAttribute("x2", "18");
line2.setAttribute("y2", "18");

svg.appendChild(line1);
svg.appendChild(line2);
removeBtn.appendChild(svg);

removeBtn.addEventListener('click', () => {
pill.style.transform = 'scale(0.9)';
Expand Down
Loading