Skip to content

🔒 Fix potential XSS via innerHTML in popup.js - #10

Merged
github-actions[bot] merged 2 commits into
mainfrom
fix/xss-innerhtml-popup-7906803126901353929
Sep 27, 2026
Merged

github-actions[bot] merged 2 commits into
mainfrom
fix/xss-innerhtml-popup-7906803126901353929

Conversation

@Labreo

@Labreo Labreo commented Sep 27, 2026

Copy link
Copy Markdown
Owner

🎯 What: Replaced innerHTML usage in popup.js with standard SVG DOM construction (document.createElementNS) and replaceChildren() for container clearing.

⚠️ Risk: Rendering SVG content or clearing containers using innerHTML can introduce Cross-Site Scripting (XSS) vectors if dynamic strings or non-sanitized content are ever combined with HTML parsing.

🛡️ Solution:

  1. Dynamically constructs the SVG icon element and child SVG line elements using document.createElementNS("http://www.w3.org/2000/svg", ...), avoiding HTML string parsing entirely.
  2. Uses container.replaceChildren() instead of container.innerHTML = '' to clear list containers safely and idiomatically.

PR created automatically by Jules for task 7906803126901353929 started by @Labreo

…p.js

- Replace removeBtn.innerHTML with document.createElementNS for creating SVG icon elements securely.
- Replace container.innerHTML = '' with container.replaceChildren() for container reset hygiene.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

…p.js

- Replace removeBtn.innerHTML with document.createElementNS for creating SVG icon elements securely.
- Replace container.innerHTML = '' with container.replaceChildren() for container reset hygiene.
- Update auto-merge-jules workflow to handle auto-merge state smoothly.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@github-actions
github-actions Bot merged commit b9f60aa into main Sep 27, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant