Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@vitejs/plugin-react": "^6.0.2",
"eslint": "^9",
"eslint-config-next": "16.3.6",
"jsdom": "^29.1.1",
"jsdom": "^30.1.2",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[CRITICAL] agentic/bug

jsdom@30 and its dependency tree require Node.js ^22.22.2 || ^24.15.0 || >=26.0.0, but the CI pipeline (.github/workflows/ci.yml line 27) runs on Node.js 20. Multiple pulled-in packages enforce this: [email protected] itself (^22.22.2 || ^24.15.0 || >=26.0.0), @asamuzakjp/[email protected] (^22.22.2 || ^24.15.0 || >=26.0.0), @asamuzakjp/[email protected] (same), [email protected] (same), [email protected] (^22.14.0 || >=24.0.0), [email protected] (^22.14.0 || >=24.0.0), [email protected] (^22.14.0 || >=24.0.0), [email protected] (^22.13.0 || >=24.0.0), and [email protected] (>=22.19.0). The CI job will fail (or behave unpredictably at runtime) with Node 20. Either bump the CI Node version to at least 22.22.2, or stay on jsdom@29 which supports Node ^20.19.0.

Suggested fix:

In `.github/workflows/ci.yml`, change `node-version: 20` to `node-version: 22` (or `node-version: lts/*`). Also update `@types/node` from `^20` to `^22` in `package.json` for consistency.

"tailwindcss": "^4",
"typescript": "^5",
"vitest": "^4.1.11"
Expand Down
Loading
Loading