Repository navigation
chore(deps-dev): bump jsdom from 29.1.1 to 30.1.2 - #22
dependabot[bot] wants to merge 1 commit into
Conversation
Bumps [jsdom](https://github.com/jsdom/jsdom) from 29.1.1 to 30.1.2. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Commits](jsdom/jsdom@v29.1.1...v30.1.2) --- updated-dependencies: - dependency-name: jsdom dependency-version: 30.1.2 dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
There was a problem hiding this comment.
This PR upgrades jsdom from v29.1.1 to v30.1.2, pulling in a cascade of updated transitive dependencies (undici, whatwg-url, tr46, html-encoding-sniffer, and various @csstools and @asamuzakjp packages). Critically, jsdom v30 and its entire dependency tree require Node.js ≥22.22.2, but the CI pipeline is pinned to Node 20, which will cause CI to fail. The CI workflow must be updated to use Node 22+ (or jsdom should be kept at v29) before this PR can be merged safely.
Findings outside the diff
These sit on lines this PR did not change, but this PR is what makes them wrong. They cannot be posted as inline comments.
- [CRITICAL]
.github:66— Process completed with exit code 1.
Reviewer callouts (1)
Non-blocking observations. Nothing here needs to change before merge.
.github:1— "The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see actions/runner-images#14748"
| "eslint": "^9", | ||
| "eslint-config-next": "16.3.6", | ||
| "jsdom": "^29.1.1", | ||
| "jsdom": "^30.1.2", |
There was a problem hiding this comment.
[CRITICAL] agentic/bug
jsdom@30 and its dependency tree require Node.js ^22.22.2 || ^24.15.0 || >=26.0.0, but the CI pipeline (.github/workflows/ci.yml line 27) runs on Node.js 20. Multiple pulled-in packages enforce this: [email protected] itself (^22.22.2 || ^24.15.0 || >=26.0.0), @asamuzakjp/[email protected] (^22.22.2 || ^24.15.0 || >=26.0.0), @asamuzakjp/[email protected] (same), [email protected] (same), [email protected] (^22.14.0 || >=24.0.0), [email protected] (^22.14.0 || >=24.0.0), [email protected] (^22.14.0 || >=24.0.0), [email protected] (^22.13.0 || >=24.0.0), and [email protected] (>=22.19.0). The CI job will fail (or behave unpredictably at runtime) with Node 20. Either bump the CI Node version to at least 22.22.2, or stay on jsdom@29 which supports Node ^20.19.0.
Suggested fix:
In `.github/workflows/ci.yml`, change `node-version: 20` to `node-version: 22` (or `node-version: lts/*`). Also update `@types/node` from `^20` to `^22` in `package.json` for consistency.
Bumps jsdom from 29.1.1 to 30.1.2.
Release notes
Sourced from jsdom's releases.
... (truncated)
Commits
a23bfb730.1.264a75d2Update dependencies and dev dependencies7bf9653Invalidate styles after CSSOM and control state changesfe9009cUpdate focused area handlinga8d28b3Release windows retained by stylesheet parsing05a2c01Deduplicate generated CSS property metadata1efa190Reduce generated CSS property dataa372e12Avoid Document named-property rebuilds after irrelevant tree mutationsb2cd235Update css-color0542d2bRelease idle MutationObserver bookkeepingDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)