Repository navigation
build(node): declare supported node versions and add nvmrc - #15
Open
mariano-aguero wants to merge 5 commits into
Open
mariano-aguero wants to merge 5 commits into
mariano-aguero wants to merge 5 commits into
Conversation
5 of 10 tasks
# Conflicts: # package.json
![justalab-agents[bot]](https://avatars.githubusercontent.com/u/159771991?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings outside the diff
These sit on lines this PR did not change, but this PR is what makes them wrong. They cannot be posted as inline comments.
- [WARNING]
package.json— package.json has dependency changes but no pnpm-lock.yaml update was found in this PR. Commit the lockfile together with manifest changes.
Reviewer callouts (1)
Non-blocking observations. Nothing here needs to change before merge.
.github:1— "The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see actions/runner-images#14748"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The repo does not say which Node versions it supports, and some of them do not work: on Node 22.11
vitestfails at startup because a rolldown binding requires^20.19.0 || >=22.12.0, and pnpm skips it. This addsengines.nodetopackage.jsonand an.nvmrcpointing at Node 20, so an unsupported version gets a clear warning at install time. CI now reads its Node version from.nvmrc, and the README lists the supported versions.Type of change
Checklist
pnpm lintpassespnpm buildpasses (type-check + build)pnpm testpassespnpm test:e2epasses (if behavior changed)E2E was not run since app behavior does not change. Lint, the 12 unit tests and the build pass on Node 20.20.1 selected through
nvm use. On Node 22.11,pnpm installnow printsUnsupported enginewith the range below.Notes for reviewers
The range
^20.19.0 || ^22.13.0 || >=24.0.0comes fromjsdomandeslint-visitor-keys, the strictest ranges inpnpm-lock.yaml, and it also covers the packages that require^22.12.0or>=20.19.0..nvmrcsays20to match justalab-agents. One transitive package,@wallet-standard/base(types only, pulled in by@wagmi/connectors), declares>=22; pnpm does not warn about it, and lint, tests and build pass on Node 20.Without
engine-strict, pnpm only warns on a mismatch and does not block the install. This PR is independent of #14 and the two can merge in any order.engine-strict=truewould turn the warning into an install error, but on Node 20 it also fails on@wallet-standard/base, so it waits for the move off Node 20, which reached end of life in April 2026.