Repository navigation
fix(deps): move pnpm overrides to the workspace file and pin pnpm - #17
Merged
Merged
Conversation
![justalab-agents[bot]](https://avatars.githubusercontent.com/u/159771991?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings outside the diff
These sit on lines this PR did not change, but this PR is what makes them wrong. They cannot be posted as inline comments.
- [WARNING]
package.json— package.json has dependency changes but no pnpm-lock.yaml update was found in this PR. Commit the lockfile together with manifest changes.
Reviewer callouts (1)
Non-blocking observations. Nothing here needs to change before merge.
.github:1— "The ubuntu-latest label will migrate to Ubuntu 26 beginning October 19, 2026. For more information, see actions/runner-images#14748"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After #16, every rebased Dependabot PR fails CI at
pnpm install --frozen-lockfilewithERR_PNPM_LOCKFILE_CONFIG_MISMATCHonoverrides. The lockfiles Dependabot regenerates have nooverridessection and bring back the versions the overrides were added to remove: axios 1.13.5, qs 6.14.1 and postcss 8.4.31 (see #12).The cause is that pnpm 11 stopped reading settings from the
pnpmfield ofpackage.json. The repo did not pin a pnpm version, so Dependabot resolves with a recent one and the overrides are silently ignored.This PR moves the overrides to
pnpm-workspace.yaml, which both pnpm 10 and 11+ read, and pinspackageManager: [email protected], which Dependabot andpnpm/action-setupboth honor. The workflow drops its ownversioninput so the version lives in one place. The lockfile does not change.Type of change
Checklist
pnpm lintpassespnpm buildpasses (type-check + build)pnpm testpassespnpm test:e2epasses (if behavior changed) N/A, no app behavior changes.Notes for reviewers
Do not merge the open Dependabot PRs as they are now: their lockfiles drop the security overrides. After this lands they need another
@dependabot rebase.Verified locally with pnpm 10.28.0 on Node 20.20.1. I could not run pnpm 11 locally (it needs Node 22.13+), so the pnpm 11 side rests on its release notes and on the Dependabot result after the rebase.
This touches
package.jsonnear theenginesfield that #15 adds, so one of the two may need a trivial rebase.