Skip to content

Lift the Aqua bound in the test environment #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michakraus merged 1 commit into from
Sep 18, 2026
Merged

Lift the Aqua bound in the test environment #298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2110,6 +2110,12 @@ so it cannot coexist with `GeometricOptimizers` 0.5.
`ambiguities` and `piracies` entries give above: a switched-off check detects nothing. Raise the
bound once Aqua handles a weak dependency in that position.

- **The Aqua bound above is lifted.** `test/Project.toml` now reads plain `Aqua = "0.8"` again.
Aqua 0.8.18, released 2026-09-18, fixes exactly the case the bound above describes — its own
release notes say `test_persistent_tasks` "no longer errors on a weak dependency that is also
listed in `[deps]` but not installed" — so `EnzymeCore` behind `KernelAbstractions` no longer
stops the manifest walk.

- **C5 is removed from *Open Issues*: its premise no longer holds.**
`.github/workflows/CI.yml` no longer pins an explicit `1.13` job — only `pre` and `nightly` are
`experimental: true` — resolved by `4281732c` ("Unify the shared GitHub workflows", 2026-08-31),
Expand Down
6 changes: 1 addition & 5 deletions test/Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,7 @@ GeometricMachineLearning = {path = ".."}

[compat]
AbstractNeuralNetworks = "0.8"
# Aqua 0.8.17's `test_persistent_tasks` builds its own manifest from each package's `Project.toml`,
# and calls `error` on a `[deps]` entry `Base.locate_package` cannot resolve. KernelAbstractions
# declares `EnzymeCore` in both `[deps]` and `[weakdeps]`, so Pkg does not install it and the walk
# stops there. Raise this bound once Aqua handles a weak dependency in that position.
Aqua = "0.8.0 - 0.8.16"
Aqua = "0.8"
ChainRulesTestUtils = "1"
FiniteDifferences = "0.12"
GeometricIntegrators = "0.18.2"
Expand Down
Loading