Repository navigation
Prevent conflicting Runway installations #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| name: macOS checks | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'Runway/**' | ||
| - 'RunwayWidget/**' | ||
| - 'Shared/**' | ||
| - 'RunwayTests/**' | ||
| - 'Runway.xcodeproj/**' | ||
| - 'scripts/**' | ||
| - 'script/**' | ||
| - 'tests/install-selfcheck.py' | ||
| - '.github/workflows/macos.yml' | ||
| push: | ||
| branches: [main] | ||
| paths: | ||
| - 'Runway/**' | ||
| - 'RunwayWidget/**' | ||
| - 'Shared/**' | ||
| - 'RunwayTests/**' | ||
| - 'Runway.xcodeproj/**' | ||
| - 'scripts/**' | ||
| - 'script/**' | ||
| - 'tests/install-selfcheck.py' | ||
| - '.github/workflows/macos.yml' | ||
|
|
||
| permissions: | ||
| contents: read | ||
|
|
||
| jobs: | ||
| test: | ||
| runs-on: macos-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: '3.12' | ||
| - name: Verify installer replacement and rollback | ||
| run: python3 tests/install-selfcheck.py | ||
| - name: Test macOS app | ||
| run: >- | ||
| xcodebuild -project Runway.xcodeproj -scheme Runway | ||
| -configuration Debug -destination 'platform=macOS' | ||
| CODE_SIGN_IDENTITY=- CODE_SIGN_STYLE=Manual DEVELOPMENT_TEAM= | ||
| -quiet test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If staging, backup archival, unregistration, or replacement fails after this loop, both refresh-agent plists have already been deleted, but
cleanup_build()only restores application bundles. The installer also terminates the running app before these operations and only reopens it on success, so an enabled background-refresh schedule remains disabled after rollback—even across login—until the user manually launches Runway again. The archival-failure fixture reproduces this: the previous app survives, but no agent plists remain and no app is reopened. Preserve the previous agent configuration and restore it on failure along with the application.Useful? React with 👍 / 👎.