Repository navigation
Prevent conflicting Runway installations - #6
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f32ea5e9a1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| echo "Could not retire $service" >&2 | ||
| exit 1 | ||
| fi | ||
| rm -f "$agent" |
There was a problem hiding this comment.
Restore refresh-agent plists when installation rolls back
If staging, backup archival, unregistration, or replacement fails after this loop, both refresh-agent plists have already been deleted, but cleanup_build() only restores application bundles. The installer also terminates the running app before these operations and only reopens it on success, so an enabled background-refresh schedule remains disabled after rollback—even across login—until the user manually launches Runway again. The archival-failure fixture reproduces this: the previous app survives, but no agent plists remain and no app is reopened. Preserve the previous agent configuration and restore it on failure along with the application.
Useful? React with 👍 / 👎.
Local installs left older app backups and a legacy alias discoverable by macOS. Archive backups, serialize replacement, preserve rollback, and retire conflicting Runway launch and widget registrations when the installed app reopens.
Validated with 140 macOS tests and six installer checks covering replacement, archival failure, rollback, symlinks, and install locking. Adds macOS CI for both suites.