Skip to content

Check the npm login before publishing #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
IsaacBell merged 1 commit into from
Oct 5, 2026
Merged

Check the npm login before publishing #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions docs/RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,10 @@ npm publish needs 2FA.
mise run publish-dry-run apps/<package>
```

3. Publish from a clean `main` (runs `mise run check` first, then `pnpm publish`, then tags
`<name>@<version>`):
3. Publish from a clean `main`. The task checks the npm login first (`pnpm whoami`; if it
fails, it runs `pnpm login` and checks again), so an expired login stops it in seconds, not
after the test suite. Then it runs `mise run check`, `pnpm publish`, and tags
`<name>@<version>`:

```bash
mise run publish apps/<package>
Expand Down
6 changes: 3 additions & 3 deletions mise.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,9 +87,9 @@ description = "Audit local capture surfaces and browser extensions (macOS/Linux)
run = "bash apps/am-i-being-recorded/bin/am-i-being-recorded.sh"

[tasks.publish]
description = "Publish one package to npm (2FA), then tag it. Usage: mise run publish apps/<package>"
depends = ["check"]
run = "bash scripts/release.sh publish"
description = "Check the npm login, run the checks, publish one package to npm (2FA), then tag it. Usage: mise run publish apps/<package>"
raw = true
run = ["bash scripts/release.sh login", { task = "check" }, "bash scripts/release.sh publish"]

[tasks.publish-dry-run]
description = "List the files one package would publish. Usage: mise run publish-dry-run apps/<package>"
Expand Down
19 changes: 18 additions & 1 deletion scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
# Release one package from this monorepo to npm. The name and version come from the
# package's own package.json, so one script serves every package.
#
# scripts/release.sh login # make sure npm is logged in (pnpm login if not)
# scripts/release.sh dry-run apps/<package> # list the files that would ship
# scripts/release.sh publish apps/<package> # publish (npm asks for 2FA), then tag
#
Expand All @@ -13,13 +14,28 @@
set -euo pipefail
cd "$(dirname "$0")/.."

registry=https://registry.npmjs.org/

die() {
echo "release.sh: $*" >&2
exit 1
}

# npm answers an upload without a valid login with 404, not 401, so check before publishing.
ensure_login() {
pnpm whoami --registry "$registry" >/dev/null 2>&1 && return
echo "release.sh: not logged in to npm; running pnpm login" >&2
pnpm login --registry "$registry"
pnpm whoami --registry "$registry" >/dev/null 2>&1 || die "still not logged in to npm"
}

if [[ ${1:-} == login ]]; then
ensure_login
exit
fi

[[ $# -eq 2 ]] || {
echo "usage: release.sh dry-run|publish <package-dir>" >&2
echo "usage: release.sh login | dry-run|publish <package-dir>" >&2
exit 2
}
action=$1
Expand All @@ -42,6 +58,7 @@ dry-run)
(cd "$dir" && pnpm pack --dry-run)
;;
publish)
ensure_login
if [[ -n "$(pnpm view "$name@$version" version 2>/dev/null)" ]]; then
die "$name@$version is already on npm; bump the version in $pkg"
fi
Expand Down
Loading