Repository navigation
Check the npm login before publishing - #4
Merged
Merged
Conversation
npm answers an upload without a valid login with 404, which only shows up after the full check suite has run. The publish task now checks the login first (pnpm whoami, then pnpm login if needed), then runs the checks.
Owner
Author
|
@codeant review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
npm answers a publish without a valid login with
404 Not Found - PUT, aftermise run checkhas already run (about 3.5 minutes).scripts/release.sh login: runspnpm whoami; if that fails, runspnpm loginand checks again.release.sh publishcalls the same check before publishing.mise run publishnow runs the login check, thencheck, then publish, in that order (raw = truesopnpm logincan prompt).checkstill runs on every publish.docs/RELEASING.mdupdated.Checked: shellcheck and shfmt clean;
release.sh loginexits 0 when logged in; no arguments prints the usage line and exits 2.