Skip to content

fix(ui): unify the button size scale app-wide - #744

Merged
smunini merged 1 commit into
mainfrom
bugfix/728-unify-button-size-scale
Aug 28, 2026
Merged

fix(ui): unify the button size scale app-wide#744
smunini merged 1 commit into
mainfrom
bugfix/728-unify-button-size-scale

Conversation

@Gordex2014

Copy link
Copy Markdown
Contributor

Closes #728.

Summary

  • Establish one canonical ordinary-action scale across the UI: 30px height, 12px horizontal padding, 12px type, and 9px radius.
  • Keep primary, danger, and current variants geometry-neutral; retire the duplicate accent variant.
  • Normalize icon actions to a 30px square and remove page-specific button geometry from the query builder, resource editor, Batch, Bulk Import, tenants, and SQL workspaces.
  • Document the component contract and make it executable through app-wide, dynamic-state, responsive, accessibility, and no-JavaScript coverage.

Reconciliation with main

Evidence

Both captures are from the final reconciled binary. Every visible .btn in these surfaces measured 30px high with 9px radius and 12px type. Emphasis changes color only.

Query Builder — icon, secondary, primary, and save actions View Definitions — secondary, danger, primary, and save actions
Query Builder button scale in dark theme SQL View Definitions button scale in dark theme

Measured examples:

  • Query Builder: Copy 30×30; Recent, Run, and Save all 30px high.
  • View Definitions: Run, Duplicate, Delete, Create New, and Save all 30px high across neutral, danger, and primary variants.

Testing

  • cargo fmt --all -- --check
  • cargo test -p helios-ui
  • npm run test:unit — 8 passed
  • cargo build -p helios-hfs --features ui
  • CI=1 HFS_E2E_BASE_URL=http://127.0.0.1:63528 npx playwright test — 270 passed, 7 expected configuration skips
  • git diff --check

@Gordex2014
Gordex2014 marked this pull request as ready for review August 27, 2026 21:28
@codecov

codecov Bot commented Aug 27, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@smunini
smunini merged commit c00362d into main Aug 28, 2026
27 checks passed
@smunini
smunini deleted the bugfix/728-unify-button-size-scale branch August 28, 2026 00:48
smunini added a commit that referenced this pull request Aug 28, 2026
Resolve app.css conflict: keep main's removal of the per-dialog
.addbox__actions .btn sizing (unified button scale, #744) and keep this
branch's #tenant-add-error.alert rule.

Claude-Session: https://claude.ai/code/session_01SqiFJQiTqM5tVwEqxuKbW8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ui: .btn--primary overrides the base button height, so Cancel and Execute mismatch on Batch/Transaction — unify the button size scale app-wide

2 participants