fix(ui): unify the button size scale app-wide - #744
Merged
Conversation
Gordex2014
marked this pull request as ready for review
August 27, 2026 21:28
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
smunini
approved these changes
Aug 28, 2026
smunini
added a commit
that referenced
this pull request
Aug 28, 2026
Resolve app.css conflict: keep main's removal of the per-dialog .addbox__actions .btn sizing (unified button scale, #744) and keep this branch's #tenant-add-error.alert rule. Claude-Session: https://claude.ai/code/session_01SqiFJQiTqM5tVwEqxuKbW8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #728.
Summary
30pxheight,12pxhorizontal padding,12pxtype, and9pxradius.30pxsquare and remove page-specific button geometry from the query builder, resource editor, Batch, Bulk Import, tenants, and SQL workspaces.Reconciliation with main
mainat92c3762bf56caeed08715560be63eafd12a3d40b.Evidence
Both captures are from the final reconciled binary. Every visible
.btnin these surfaces measured30pxhigh with9pxradius and12pxtype. Emphasis changes color only.Measured examples:
30×30; Recent, Run, and Save all30pxhigh.30pxhigh across neutral, danger, and primary variants.Testing
cargo fmt --all -- --checkcargo test -p helios-uinpm run test:unit— 8 passedcargo build -p helios-hfs --features uiCI=1 HFS_E2E_BASE_URL=http://127.0.0.1:63528 npx playwright test— 270 passed, 7 expected configuration skipsgit diff --check