fix(ui): align Bulk Import detail actions with design - #748
Merged
Conversation
smunini
approved these changes
Aug 28, 2026
smunini
added a commit
that referenced
this pull request
Aug 28, 2026
Resolve bulk-import template conflicts with main's #748 (bulk import detail actions): keep the dialog::modal/dialog::field macros from this branch and extend them with a marker param (data-bulk-import-add-manifest on the Add Manifest <details>) and an initial_focus param (data-addbox-initial-focus on each dialog's first field); keep main's terminal-state disabled Add Manifest button as raw markup. Claude-Session: https://claude.ai/code/session_01SqiFJQiTqM5tVwEqxuKbW8
angela-helios
added a commit
that referenced
this pull request
Aug 28, 2026
The first heal gave #748's ruleless hook class its own padding, which broke the very parity its spec enforces - the two empty states must share one computed signature. A selector hook is not vocabulary: it moves to data-empty=manifests, the class list returns to the bare shared .empty-state, and the page object, nojs spec, and Rust assert follow.
smunini
added a commit
that referenced
this pull request
Aug 28, 2026
Both sides independently replaced #748's ruleless .bulk-import-manifest-empty marker class with a data attribute. Keeps main's data-bulk-import-manifest-empty, which matches the page's existing data-bulk-import-* hooks; the template, page object, nojs spec, and Rust assert all follow it. Claude-Session: https://claude.ai/code/session_0169dqJaApLYpi5vSzD5MEvk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Submitvisible on each row and move row-specificAbortandRemoveactions into an accessible overflow menu.Submit Allcontrol with a workingMost recentandOldestsort menu.Edit,Delete,Abort, andCompletewith the approved detail composition and add a working Edit Submission dialog.State behavior
Compatibility
Validation
cargo fmt --all -- --checkgit diff --checkcargo test -p helios-uihelios-uiintegration suites passed.cargo test -p helios-rest --test bulk_submitcargo build --bin hfsQA evidence
The captures below show, in order:
Closes #733
Closes #734
Depends on #744