Repository navigation
Owners can turn video avatars and banners off, and every client learns what the host can do with uploads (GRYT-1664) - #276
Merged
Conversation
…s what the host can do with uploads (GRYT-1664) Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sivert's ask: a server hosted any way should work in the client like a dedicated one, and where it can't, the owner and the members are told instead of finding out from a failed upload.
server_config.video_profilesis a new column,INTEGER NOT NULL DEFAULT 1. It's on by default and only matters where the worker can transcode video.settingsView(owner settings and the management API) gainsvideoProfiles, andmedia: { checked, video }from the worker's capabilities, so the client can say why the switch is greyed out.server_infogainsuploads_checkedandvideo_profiles(host can transcode and the owner allows it), so members' pickers offer video only where it works.video_disabled, "This server's owner has turned off video avatars and banners. Use a picture instead." The existingvideo_unsupportedstill covers a host that can't.Tested: the banner-video case in
uploadQuarantine.test.tsturns the switch off and back on. The full suite passes (1968).Review-required:
src/db/sqlite/connection.ts(new column and migration),servers.ts,interfaces.ts. The client half is alongside.🤖 Generated with Claude Code