Stop holding hidden conversations (GRYT-1379)

[sivert-io]

Hiding a conversation was a row on the server. dm:setHidden set conversation_members.hidden_at, listConversationsForUser filtered those rows out, and a new message cleared it for everybody. Sivert wants it on the device instead: "it should purely be a visual thing", and "i dont want the server to hold it".

So the server lets go of it, and the client does the hiding on its own: Gryt-chat/client#649. The socket reference documented both events, so Gryt-chat/docs#129 drops them. Task: https://tasks.sivert.io/tasks/1456

What changes

• listConversationsForUser stops filtering on hidden_at, so the list holds every conversation again.
• dm:setHidden and the dm:hidden event are gone, along with setConversationHidden and clearConversationHidden.
• dm:open no longer unhides, and chat:send no longer unhides everybody in the conversation. The first message in a new conversation still announces it, which is what that block was doing as well.
• A one-shot migration clears every hidden_at the old code wrote, stamped in schema_meta so it runs once.

Without that clear, anything hidden before today would stay filtered out for good: the new client can only draw what it is sent, and it is never sent those rows.

The column stays

conversation_members.hidden_at is kept, unused. Dropping it is a rebuild of the table in SQLite, and an older binary rolling back would then write to a column that isn't there. Keeping it costs one TEXT column per membership row and nothing reads it.

What to look at

Blocking. user:block used to call hideConversationsBetween, which took the blocked person's conversation off the blocker's list through the same column. With the filter gone that write does nothing, so leaving it in would be a line that reads as working and isn't. I deleted it, and the client hides the row locally when a block lands instead. Same effect, and it can be found again under Hidden rather than being gone for good. That's the part I'm least sure about, since it's the one place the two halves have to agree.

One thing I expected to lose and didn't: today a blocked person's message already unhides the blocker's row, because clearConversationHidden unhid everybody in the conversation without asking who. The client rule has the same hole, so blocking behaves as it did.

chat:send. The wasEmpty announce loop is the same set it always sent; it just no longer unions in whoever clearConversationHidden reported.

The rest is shape rather than behaviour.

Tested

yarn test (1454 tests), yarn test:examples, yarn build, npx eslint ., the comment-length and self-hosted-config checks, all green.

The tests that covered hiding now cover letting go of it: dm:setHidden is not registered, a conversation still carrying hidden_at is listed, and the migration clears the column once and leaves the marker behind so a second run doesn't.

Also run against a real client: a throwaway server built from this branch, the client's Playwright suite on the other end, two accounts hiding and unhiding conversations between them.

The reference check

reference / Compare the reference pages against the source is red here and stays red until Gryt-chat/docs#129 lands: check-socket-coverage.mjs fails hard on an event the page describes and the server doesn't have. The docs PR is green on its own, so it goes first. verify is green here.

Accepted

Once a server updates, Hide in an older client does nothing. It writes hidden_at that nothing reads, and the row stays in the list.

Don't merge this one. It's yours to read first.

🤖 Generated with Claude Code