Repository navigation
Drop the two hidden-conversation events from the socket reference (GRYT-1379) - #129
Merged
Merged
Conversation
…YT-1379) `dm:setHidden` and `dm:hidden` are gone from the server: hiding a conversation is the client's own now, kept on the device and sent nowhere. The page said otherwise, which fails the socket coverage check on the server's pull request. Gryt-chat/server#217 and Gryt-chat/client#649. Co-Authored-By: Claude Opus 5 <[email protected]>
This was referenced Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The socket reference lists
dm:setHiddenanddm:hidden. Gryt-chat/server#217 removes both: hiding a conversation is the client's own now, kept on the device and sent nowhere. Gryt-chat/client#649 is the other half. Task: https://tasks.sivert.io/tasks/1456check-socket-coverage.mjsfails hard on an event the page describes and the server doesn't have, so this has to land before the server PR can go green. It passes on its own: the two events being in the server's source and not on the page only counts towards the 70% floor, and coverage stays well above it.The section also gains a line saying where hiding lives now, so nobody goes looking for the event that used to be there.
🤖 Generated with Claude Code