Repository navigation
Pin messages (GRYT-1619) - #807
Merged
Merged
Conversation
Pin Message and Unpin Message sit in a message's right-click menu, for whoever has manage_messages in a channel and for anyone in a DM. A pinned message gets a small "pinned" mark, and the pin button in the header opens the list. Needs server#281. An older server ignores chat:pin, so the item does nothing there. Co-Authored-By: Claude Opus 5.5 <[email protected]>
At 300px a DM header with call buttons ran 8px past the window edge once the pin button joined it (dm.spec.ts). Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client half of pinned messages. The server half is Gryt-chat/server#281.
What's in it
manage_messagesin a channel, and for anyone in a DM, which is the same rule the server enforces. Not on MLS messages, since the server has no copy of those.usePinslistens forchat:pinned, so a pin made by somebody else shows straight away.Tested against a local server running the server#281 branch: pinned a message, saw the mark and the list, reloaded and the pin was still there, then unpinned it.
yarn lintpasses.Known gaps
scrollToMessageonly knows about loaded rows. Same as reply jumps today.🤖 Generated with Claude Code