Repository navigation
Pin messages on the phone (GRYT-1678) - #302
Merged
Merged
Conversation
Hold a message and pick Pin or Unpin. It's offered to whoever has manage_messages in a channel and to anyone in a DM, the same rule the server uses. A pinned message shows "pinned" under it, and the pin button in the header opens the list. Picking a pin scrolls to it when it's loaded. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
|
Checked on the iPhone 17 Pro simulator: dev client on this branch's Metro, against a local server at main (pins, 98f93e6). I was an owner in a #general seeded with 120 messages, two of them pinned (3 and 115).
Not checked: a DM, a member without manage_messages (the item should be hidden), and Android. Server 1.10.56 with pins is on stable now, so the "don't merge before the server is on latest" note no longer applies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The phone half of pinned messages. The server half is server#281, out as 1.10.56-beta.2. The desktop half is client#807.
What's in it
manage_messagesin a channel, or as anyone in a DM. MLS messages and unsent ones don't get them.useMessageslistens forchat:pinned, so a pin made on another device shows straight away.Not verified on a device yet. Typecheck and the test suite pass (1395). In the simulator, the dev build kept reopening an old test server, and I couldn't switch it to the local pins server with injected taps. Someone needs to hold a message on a server running 1.10.56-beta.2 before this merges.
Don't merge before the server is on latest. On a stable server the Pin item does nothing.
🤖 Generated with Claude Code