Repository navigation
Pull in verified CommonLib RE fixes and data - #3
Open
NomadsReach wants to merge 8 commits into
Open
NomadsReach wants to merge 8 commits into
NomadsReach wants to merge 8 commits into
Conversation
NomadsReach
force-pushed
the
sync/public-re-fixes-20260925
branch
from
September 26, 2026 04:28
7942419 to
0724e3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulled in the CommonLib RE fixes/data I could actually verify across the different forks and related projects.
Changes
NiMatrix3::IDENTITY.NiObjectNET::AddExtraDataname handling.NiObjectNET::InsertExtraDataso it creates the container when needed and rejects null input.TESLeveledListcount fields to unsigned bytes.TESDataHandler::CompileFilesTESDataHandler::ConstructObjectListTESDataHandler::InitAllFormsIDs
CompileFiles571372192321ConstructObjectList10432802192326InitAllForms1892232192344The TESDataHandler IDs were cross-checked against the runtime validation work in Addictol.
I also added
UPSTREAM_RESEARCH.mdso we have a record of what was checked, what is already in this fork, and what still needs verification.I did not pull in anything where the runtime data conflicts or where we only have AE IDs. Those are listed in the research file so we can keep working through them without guessing.
Latest research batch
Pulled in the save/load, inventory serialization, tinting, and texture bindings that had enough proof to use.
Sources:
Full notes and the stuff I am still holding back are in
UPSTREAM_RESEARCH.md.