Skip to content

Pull in verified CommonLib RE fixes and data - #3

Open
NomadsReach wants to merge 8 commits into
mainfrom
sync/public-re-fixes-20260925
Open

NomadsReach wants to merge 8 commits into
mainfrom
sync/public-re-fixes-20260925

Conversation

@NomadsReach

@NomadsReach NomadsReach commented Sep 26, 2026 •

Copy link
Copy Markdown

Pulled in the CommonLib RE fixes/data I could actually verify across the different forks and related projects.

Changes

  • Fixed NiMatrix3::IDENTITY.
  • Fixed NiObjectNET::AddExtraData name handling.
  • Fixed NiObjectNET::InsertExtraData so it creates the container when needed and rejects null input.
  • Corrected the TESLeveledList count fields to unsigned bytes.
  • Added:
    • TESDataHandler::CompileFiles
    • TESDataHandler::ConstructObjectList
    • TESDataHandler::InitAllForms

IDs

Function OG NG/AE
CompileFiles 57137 2192321
ConstructObjectList 1043280 2192326
InitAllForms 189223 2192344

The TESDataHandler IDs were cross-checked against the runtime validation work in Addictol.

I also added UPSTREAM_RESEARCH.md so we have a record of what was checked, what is already in this fork, and what still needs verification.

I did not pull in anything where the runtime data conflicts or where we only have AE IDs. Those are listed in the research file so we can keep working through them without guessing.

Latest research batch

Pulled in the save/load, inventory serialization, tinting, and texture bindings that had enough proof to use.

Sources:

Full notes and the stuff I am still holding back are in UPSTREAM_RESEARCH.md.

@NomadsReach NomadsReach changed the title Sync/public re fixes Sync verified public RE fixes and runtime data Sep 26, 2026
@NomadsReach NomadsReach changed the title Sync verified public RE fixes and runtime data Pull in verified CommonLib RE fixes and data Sep 26, 2026
@NomadsReach
NomadsReach force-pushed the sync/public-re-fixes-20260925 branch from 7942419 to 0724e3f Compare September 26, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant