[joswalt]

Problem

Folio can reorder pages and export a selection, but it can't delete a page. Dropping a blank or duplicate page means switching to another app. This is the first of three pull requests for #69 (delete, then rotate, then insert).

Change

• Reorder pages becomes Organize pages. It works as before: changes are a draft shown on the thumbnails, and Save downloads a new copy, so the original file and the open tab are never changed. Dragging and the "Move page N to" field still move one page at a time.
• Ctrl-click (⌘-click on macOS) and Shift-click select several pages, as in the Pages tab since Export selected PDF pages from the thumbnail menu #68.
• Delete removes the selected pages, from the toolbar or with Delete or Backspace, without asking, since nothing is saved until Save. It's unavailable when it would remove every page.
• Undo and redo inside the organizer (Ctrl+Z, Ctrl+Shift+Z or Ctrl+Y; ⌘ on macOS) step through deletes and moves. Cancel discards everything.
• Right-clicking selected thumbnails in the Pages tab offers Delete next to Export. It opens the organizer with those pages already removed, so Undo can bring them back.
• The copy is called "name (organized).pdf", with Open organized copy; both replace the "(reordered)" wording. Highlights and notes are saved into the copy as before; marks on deleted pages are dropped.
• Version history shows the new order compressed into ranges ("4, 1–3, 5–100") only when pages moved, and lists deleted pages. It no longer says "Updated annotations" when every mark was on a deleted page. Form-field values don't record their page, so they still count as surviving.
• The keyboard shortcut list and the README include the organizer's shortcuts.

Issue or approval

Part of #69. Approved here: #69 (comment)

How I checked it

• macOS, on this branch alone (rebased on 0590fac):
  • npx tsc --noEmit and npm run build passed.
  • npm run test:thumbnails (15), npm run test:chat-math (18), npm run test:reader-security (8), scripts/test-link-history.mjs (7) and scripts/test-openrouter.cjs (4) passed.
  • The node --test step from CI passed (26 passed, 1 Windows-only test skipped).
  • npm run smoke passed twice.
• The new smoke check, "organizing pages deletes, undoes and redoes, keeps at least one page, and saves the chosen pages in order":
  • deletes pages from the Pages tab's menu, and Undo brings them back still selected;
  • checks that the Delete button and the Delete key do nothing when every page is selected;
  • covers Ctrl/⌘-click selection, Delete, Backspace, undo, redo, and dragging a page;
  • checks that focus moves to the selected page after a menu action;
  • reads the saved copy and checks its exact pages and order.
• The existing reorder checks were updated for the new names and still pass, including filled form fields in the copy and annotations following their pages.
• Windows and Linux: not run myself; CI covers both.

Before (Reorder pages, and the Pages tab's menu with two pages selected) and after (the same menu with Delete, Organize pages with pages selected, and after deleting them):

[before-reorder-pages.png]

[before-pages-menu.png]

[after-pages-menu.png]

[after-organize-selected.png]

[after-organize-deleted.png]

[joswalt]

@mberman84 - Can you review this PR when you have a chance? I addressed your comments and the CI is green. Once this PR is merged, I will create the follow-up PRs.

[mberman84]

I reproduced an annotation-loss regression on 8be713e in the hidden macOS app, even with the organizer closed. Highlight a line, edit a different line in Edit mode, then save a copy. The PDF exported before the text edit contains the highlight. The copy exported after the text edit has no highlight. With the same synthetic document and same steps on base 264e193, the highlight is present in both copies.

In src/App.tsx, the content editor passes an empty page array to currentBytes to request the full document. The new kept-page filter treats that empty array as keeping zero pages, skips the page-indexed annotation entries, and takes the original PDF bytes for the edit. Please apply the filter only for a nonempty page subset and add a regression check that reads the highlight back from the edited copy.

The organizer’s save path now waits for markup restoration and passes the retained page order into OCR export as requested. All three CI jobs passed on the reviewed commit.

[joswalt]

@mberman84 Could you take another look when you have a chance?

The edited PDF now preserves existing highlights, and the smoke test reads the highlight back from the saved copy. I also fixed the pen smoke test to wait for the ink layer before starting a stroke. Windows, macOS, and Linux CI all passed on 38d883c.