Repository navigation
v2.0.0: tactic engine - #139
Merged
Merged
Conversation
…-Strategy, round_robin --help - ci.yml: skip the test report on a cancelled run; it has no results file and failed, showing a red X for tests that never ran. - release.yml: stop bumping Utama-Strategy's utama-core pin on every release. Utama-Strategy is stale and written against the pre-tactic-engine API. - round_robin.py: -h/--help prints the docstring, which now lists every flag; it used to be taken for a config name. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01SACGSprm9GiBueqKdxsy2j
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused workflow and CLI changes are consistent with the release goal and adequately tested.
Review effort: Balanced
Findings: None
What changed in this PR
Prepares the v2.0.0 release while improving CI cancellation handling and tournament CLI help.
Changes:
- Skips test reporting for cancelled CI runs.
- Removes updates to the stale Utama-Strategy repository.
- Adds comprehensive round-robin CLI help with regression coverage.
| File | Description |
|---|---|
.github/workflows/ci.yml |
Avoids reports for cancelled tests. |
.github/workflows/release.yml |
Removes stale dependent-repository updates. |
tools/tournament/round_robin.py |
Adds -h/--help usage output. |
utama_core/tests/engine/test_tournament_cli_args.py |
Tests both help flags. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releases the tactic-engine update as v2.0.0.
mainwas fast-forwarded totactic-engine(b0ba382e) without a pull request, so the release workflow never ran andmainstill says v1.11.11. Merging this withrelease:majortags v2.0.0.What v2.0.0 contains (on
mainsinceb0ba382e): the tactic-kernel strategy model (engine/,strategy/one module per strategy,tactics/), the in-process referee, the fpp planner as default, round-robin and scenario-bench evaluation with result reuse,analysis/split fromreplay/, scripts moved totools/andexamples/, and thestrategy/*branch check. Imports and paths changed throughout, hence major.This PR's own changes:
utama-corebump to Utama-Strategy on every release. It is stale and written against the old API, so the bump would break it. This PR's own merge already runs without that step.-h/--helpprints usage listing every flag (it was taken for a config name), with a regression test.🤖 Generated with Claude Code
https://claude.ai/code/session_01SACGSprm9GiBueqKdxsy2j