[MelvinBot]

Details

Fixes GHSA-fv7c-fp4j-7gwp (high): @babel/plugin-transform-modules-systemjs ≤7.29.3 can generate arbitrary code from malicious input.

Lockfile-only. It bumps @babel/plugin-transform-modules-systemjs from 7.28.5 to 7.29.8. Its new peer minimums also pull the shared Babel core packages to 7.29.x. @babel/core swaps @ampproject/remapping for @jridgewell/remapping. package.json is unchanged.

Usage: dev-only and transitive (react-native → @react-native/codegen → @babel/preset-env). Onyx never compiles SystemJS modules. The shared Babel core packages power Jest (babel-jest + babel.config.js). The published dist/ comes from tsc, so consumers are unaffected.

Change Log

• v7.29.8: systemjs supports __proto__ as an export name; spec-compliance fixes in generator, parser, traverse, and types.
• v7.29.7 / v7.29.6: bug fixes in babel-core and babel-generator.
• v7.29.4: security fix: systemjs improves module string name support (#17974).
• v7.29.3: parser spec compliance; class-features and decorators fixes.
• v7.29.2: parser spec compliance; helpers and preset-env fixes.
• v7.29.1: generator fix.
• v7.29.0: new babel-types features; parser and traverse fixes; generator performance.
• v7.28.6: bug fixes across core, traverse, types, and plugin-utils.

Related Issues

https://github.com/Expensify/Expensify/issues/695673

Linked E/App PR

Automated Tests

No new tests (dependency bump only). Locally, npm ci, npm run lint, and npm run build pass. npm test: 22/23 suites pass. SQLiteProviderTest fails only because the sandbox can't load the better-sqlite3 native binary, which is unrelated.

Manual Tests

1. npm ci. Confirm npm ls @babel/plugin-transform-modules-systemjs shows ≥7.29.4.
2. npm test. Confirm all suites pass.
3. npm run lint && npm run build. Confirm both succeed.

Author Checklist

• I linked the correct issue in the ### Related Issues section above
• I linked the corresponding Expensify/App PR in the ### Linked E/App PR section above, and verified this change against it (E/App CI passed and manual testing completed)
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-26T13:09:59.371586Z	4517289	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[github-actions]

All contributors have signed the CLA ✍️ ✅
_{Posted by the CLA Assistant Lite bot.}

[MariaHCD]

@NikkiWines does this need a corresponding App PR? 🤔

Error: The "Linked E/App PR" section is empty. Every Onyx PR must link to a corresponding Expensify/App PR that pins this PR via git+https and runs the full E/App test suite.

[NikkiWines]

Seems like no, so tests will continue to fail

[NikkiWines]

looks like we'll need another change to fix the CLA failure as well. I thought maybe Expensify/GitHub-Actions#123 would've solved it 🤔

[MariaHCD]

recheck

[MariaHCD]

Commented recheck started a fresh run of the CLA check

Context: https://github.com/Expensify/Expensify/issues/695678#issuecomment-6421378309

[MariaHCD]

This is also not relevant for this PR

[os-botify]

🚀 Published to npm in 3.0.128 🎉

[melvin-bot]

@MariaHCD looks like this was merged without a test passing. These checks had not passed on 4517289 when it was merged:

• validate-checklist (failure)

Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.