Skip to content

[HOLD on https://github.com/Expensify/App/pull/103351]react-native-onyx 860 array deep equal - #104984

Draft
jmusial wants to merge 11 commits into
Expensify:mainfrom
software-mansion-labs:feat/react-native-onyx-860-array-deep-equal
Draft

[HOLD on https://github.com/Expensify/App/pull/103351]react-native-onyx 860 array deep equal#104984
jmusial wants to merge 11 commits into
Expensify:mainfrom
software-mansion-labs:feat/react-native-onyx-860-array-deep-equal

Conversation

@jmusial

@jmusial jmusial commented Oct 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Explanation of Change

Based on #103351 due to Onyx.disconnect changes.

react-native-onyx PR: Expensify/react-native-onyx#860

Fixed Issues

$ #104725
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

fabioh8010 and others added 7 commits October 7, 2026 15:27
@fabioh8010
Use newest Onyx changes
7815c67
@fabioh8010
Replace Onyx.disconnect with connection.unsubscribe
e3b9aca 
Onyx.disconnect() is removed in favor of calling unsubscribe() directly on
the Connection returned by connect()/connectWithoutView().
@fabioh8010
Merge remote-tracking branch 'origin/main' into feature/onyx-disconne…
6906f7e 
…ct-removal

# Conflicts:
#	src/libs/actions/Link.ts
#	src/libs/migrations/ConvertGpsPointsTo2DArray.ts
#	tests/actions/IOUTest/HoldTest.ts
@fabioh8010
Use newest Onyx changes
5a35f8b
@fabioh8010
Merge remote-tracking branch 'origin/main' into feature/onyx-disconne…
8438cda 
…ct-removal
@fabioh8010
Replace Onyx.disconnect usages added on main
534c0cf
@jmusial
test changes for react-native-onyx/860
1113813
@github-actions

github-actions Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

@jmusial jmusial changed the title Test branch for react native onyx 860 array deep equal react-native-onyx 860 array deep equal Oct 26, 2026
@jmusial jmusial mentioned this pull request Oct 26, 2026
Merged
42 tasks done
@jmusial jmusial changed the title react-native-onyx 860 array deep equal [HOLD on https://github.com/Expensify/App/pull/103351]react-native-onyx 860 array deep equal Oct 27, 2026
@jmusial jmusial mentioned this pull request Oct 27, 2026
Open
@codecov

codecov Bot commented Oct 27, 2026 •
edited by github-actions Bot
Loading

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...n/Context/MultifactorAuthenticationMainContext.tsx 87.06% <100.00%> (ø)
src/libs/Network/SequentialQueue.ts 93.25% <100.00%> (ø)
src/libs/actions/Device/index.ts 92.00% <100.00%> (ø)
src/libs/actions/Export.ts 73.07% <100.00%> (ø)
src/libs/actions/ImportSpreadsheet.ts 81.08% <100.00%> (ø)
src/libs/actions/Link.ts 68.35% <100.00%> (ø)
src/libs/actions/OnyxDerived/index.ts 97.94% <100.00%> (ø)
src/libs/cleanupPreMountedDraftReports.ts 100.00% <100.00%> (ø)
...migrations/MoveFilesOutOfDocuments/index.native.ts 100.00% <100.00%> (ø)
...bs/migrations/RenameLegacySageIntacctExportDate.ts 100.00% <100.00%> (ø)
... and 10 more
... and 34 files with indirect coverage changes

@fabioh8010 fabioh8010 mentioned this pull request Oct 30, 2026
Open

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jmusial jmusial

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jmusial @fabioh8010