Repository navigation
Allow linking Plaid to an existing bank account and fixing existing Plaid connection #98567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dominictb
wants to merge
118
commits into
Expensify:main
Choose a base branch
from
dominictb:feat/Plaid-linking-and-fixing
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+796
−41
Open
Changes from all commits
Commits
Show all changes
118 commits
Select commit
Hold shift + click to select a range
7ffa5bf
Add LinkPlaidToBankAccountParams params
dominictb 550fcf0
Add LinkPlaidToBankAccountParams command
dominictb 336777d
Add LinkPlaidToBankAccountParams command action
dominictb fab8c41
Add requiresPlaidHandler to BankAccountConnectionStatus
dominictb 2516cf2
Add plaid status helpers
dominictb 92d5711
Return right RBR for plaid connection status
dominictb bf4d72b
Add helper to check Plaid connection eligibility
dominictb 61183b8
Update getBankAccountConnectionStatus to check Plaid connection eligi…
dominictb 5c33de7
Update getBankAccountConnectionStatus usage to pass accountData
dominictb 3f80da6
Add selector to select policyIDs on Card waitlist
dominictb c45bb1a
Get policyIDs on Card waitlist from Onyx
dominictb 467234c
Check each payment method's Plaid connection eligibility
dominictb 3368cbd
Define Plaid handler
dominictb 5a047dd
Add link plaid page route
dominictb e53957a
Init LinkPlaidToBankAccountPage
dominictb 146ff5d
Add English translations for connection status
dominictb fddc901
Add English translations for LinkPlaidToBankAccount page
dominictb e8893f0
Run generateTranslations script
dominictb 6ee05e1
Add needsFixing to BankAccount model
dominictb 6b50597
Update LinkPlaidToBankAccount action to update to bankAccountList dir…
dominictb 583b233
Export functions
dominictb 36e8484
Update action to set isLoading only
dominictb c5540c0
Remove success state from BankAccount model
dominictb 73cedbc
Render Plaid link
dominictb 1730c01
Link Plaid to bank account on success
dominictb c68accb
Handle success case
dominictb d9b2c93
Handle failure case
dominictb 94f217b
Handle wrong bank account error
dominictb d218325
Use an Onyx selector
dominictb 70ea1aa
Fix lint
dominictb e4a604e
Allow users to select Plaid account to link
dominictb fbd1f1d
Fix lint
dominictb 18fadb5
Update tests
dominictb 31b988c
Fix lint
dominictb 63b91a8
Add illustration files
dominictb 58187c9
Substitue illustrations
dominictb 9f79712
Update page location
dominictb dbf0c06
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 4b6adab
Fix test
dominictb 51a621a
Update condition
dominictb 513871d
Fix test
dominictb 130f8c8
Add brickRoadIndicator to ConnectionStatusMessage
dominictb bc571a2
Pass brickRoadIndicator to ConnectionStatusMessage
dominictb 16e87cf
Show icon for INFO brickRoadIndicator
dominictb cd6051e
Show success button based on statusTone
dominictb 55a6664
Update Fix case message
dominictb 63f35ea
Add statusBadgeTone to differentiate badge and message tone
dominictb ac052c8
Set badgeTone as success so Active badge not shown as error
dominictb 018213d
Fix test
dominictb 129a6bb
Update LinkBankAccountToPlaid param
dominictb 8c11957
Update account selector UI
dominictb 1c90757
Call OpenPlaidBankAccountSelector to get plaidAccountID and plaidAcce…
dominictb 0d642d6
Fix mode does not need Plaid credentials
dominictb eb7db7c
Remove account selector UI
dominictb 5839406
Automatically select account based on last four mask
dominictb 8057a6d
Auto submit the resolved bank account
dominictb e18ccb1
Do not allow retrial
dominictb 6c32010
remove redundant variables
dominictb 7459c69
Fix lint
dominictb 36d9803
Exclude fix mode
dominictb 161ec42
Fix lint
dominictb 670ec7b
Update LinkPlaidToBankAccount parameters
dominictb 90ee494
Let LinkPlaidToBankAccount automatically resolves the account without…
dominictb 61e6ef9
Remove unused code
dominictb 403cbb6
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 67d1765
Update description text style
dominictb a4e7234
Update description text style
dominictb 8c6f9d3
Pass the matching waitlisted policy to the link command
dominictb e989874
Surface generic link failures in the account state
dominictb aa474de
CONSISTENCY-14
dominictb 67eae49
Applied translations
dominictb 04a865a
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb cacdafc
Remove brickRoadIndicator prop
dominictb 4ea35b7
Show success message in GBR style
dominictb 9e7adfe
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 61b8d50
Update GBR and RBR text color to match Badge text color
dominictb c511d2a
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 1eeca6e
Do not append generic error message
dominictb a120ad1
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb fda630f
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb a95a957
Drop policyID from command parameters
dominictb 341ea30
Update callers
dominictb 43d8d20
Remove the helper to resolve policyID param
dominictb 6c586ac
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 6462aa8
Remove unused icon
dominictb 800ced5
Add renderer for GBR tag
dominictb 99c137b
Add the renderer to the list of HTML renderers
dominictb 5a25f83
Style the GBR
dominictb 38fbd32
Render rbr tag for success text
dominictb 302c730
Drop redundant import
dominictb 0a7bafd
Combine succes and failureData as finallyData
dominictb c82ca37
Use Set for card on waitlist policyIDs
dominictb f5b787a
Use Set for card on waitlist policyIDs
dominictb c4d40aa
Drop redundant condition
dominictb 5393bb6
Update tests
dominictb 104f270
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 2d177cd
Fix lint
dominictb 34f9077
Add accessibility label for the action button
dominictb 98e0d5d
Add accessibility label for the action button
dominictb ba74037
Annouce results
dominictb d49edaa
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 495c713
Add missing field to AccountData type
dominictb f9bfbed
Check settlement account by AccountData as well
dominictb 350bc9b
Revert bad merge commit changes
dominictb b652f1e
Drop GBRRenderer now that its style is already defined in base engine
dominictb 67f8bfb
Add tests for new field
dominictb 51e4fd7
Add an util to check if any BA needs Plaid fixing
dominictb 8331342
Show RBR in case Plaid needs fixing
dominictb e2e5100
Update tests for the RBR
dominictb fafd2ff
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb 2304e7b
Add the errorFields to bank account model
dominictb f450bc0
Add the Plaid wrong account error constant
dominictb 0734ea1
Clear the errorFields properly
dominictb 165fbf6
Show the error
dominictb 8455a4b
Merge branch 'main' of github.com:dominictb/App into feat/Plaid-linki…
dominictb b4e1078
Add Plaid linking params to navigation parameters
dominictb c0c59a8
Fix typecheck
dominictb 203747c
Specify receivedRedirectURI for Plaid Link
dominictb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1 change: 1 addition & 0 deletions
1
assets/images/simple-illustrations/simple-illustration__bank-check.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions
1
assets/images/simple-illustrations/simple-illustration__bank-x.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.