Repository navigation
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
A few small things, flagged here. Otherwise working well! |
The RBR is still missing |
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
RBR is looking good. |
joekaufmanexpensify
left a comment
joekaufmanexpensify
left a comment
There was a problem hiding this comment.
Good for product
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #90572 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
Apologies for the delay, I'll aim to review tomorrow! |
| <PlaidLink | ||
| token={plaidLinkToken} | ||
| onSuccess={({publicToken}) => { | ||
| Log.info('[PlaidLink] Success!'); | ||
| linkPlaidToBankAccount(bankAccountID, publicToken); | ||
| }} | ||
| onError={(error) => Log.hmmm('[LinkPlaidToBankAccount] PlaidLink error: ', error?.message)} | ||
| onEvent={() => {}} | ||
| onExit={() => Navigation.goBack(backPath)} | ||
| /> |
There was a problem hiding this comment.
@dominictb @bernhardoj have either of you tested on mWeb and native? I didn't see videos for them in the checklists. And Claude is suggesting we need to pass the receivedRedirectURI prop, otherwise the flow cannot be completed on mweb for OAuth banks
There was a problem hiding this comment.
Seems like this is happening for other flows too because the Link token is not persisted and thus cannot survive the redirection roundtrip. But let me check it.
This branch has not been deployed
10 participants
Explanation of Change
We're bringing Plaid reconnection/linking flow to NewDot in these cases:
Fixed Issues
$ #90572
PROPOSAL:
Tests
Test case 1: Link Plaid to an existing BBA
Precondition:
0000ConnectTest case 2: Fix (relink) a Plaid connection
Precondition:
FixOffline tests
QA Steps
Same as Test case 1: Link Plaid to an existing BBA
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Fix connection
Screen.Recording.2026-08-24.at.22.09.09.mov
Connect to Plaid
Screen.Recording.2026-08-24.at.16.35.46.mov