Skip to content

[No QA] Block compromised Java certificates in CI #104804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
roryabraham wants to merge 1 commit into from
Closed

[No QA] Block compromised Java certificates in CI #104804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/buildAndroid.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,9 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@main

- name: Setup 1Password CLI and certificates
uses: Expensify/GitHub-Actions/setup-certificate-1p@main
with:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publishReactNativeAndroidArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ jobs:
- name: Setup Gradle
uses: gradle/actions/setup-gradle@50e97c2cd7a37755bbfafc9c5b7cafaece252f6e

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@main

- name: Determine new patched RN version
id: getNewPatchedVersion
run: echo "NEW_PATCHED_VERSION=$(./.github/scripts/getNewPatchedRNVersion.sh)" >> "$GITHUB_OUTPUT"
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/publishReactNativeiOSArtifacts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,6 +234,9 @@ jobs:
path: /tmp/ios-artifacts
merge-multiple: true

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@main

- name: Publish to GitHub Packages Maven
run: ./android/gradlew -p scripts/artifacts-utils/ios/publish publish -PartifactsDir="/tmp/ios-artifacts" -PpatchedVersion="${PATCHED_VERSION}" -PpatchesHash="${PATCHES_HASH}" -PpackageName="${PACKAGE_NAME}"
env:
Expand Down
12 changes: 12 additions & 0 deletions .github/workflows/remote-build-android.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,16 @@ jobs:
with:
IS_HYBRID_BUILD: ${{ matrix.is_hybrid_build && 'true' || 'false' }}

- name: Setup Java
uses: actions/setup-java@be666c2fcd27ec809703dec50e508c2fdc7f6654
with:
distribution: adopt
java-version: 17
cache: gradle

- name: Block compromised Java certificates
uses: Expensify/GitHub-Actions/block-compromised-java-certificates@main

- name: Configure AWS Credentials
# v6
uses: aws-actions/configure-aws-credentials@99214aa6889fcddfa57764031d71add364327e59
Expand All @@ -98,6 +108,8 @@ jobs:
GITHUB_TOKEN: ${{ github.token }}
IS_HYBRID_APP: ${{ matrix.is_hybrid_build }}
with:
# Keep the protected JVM instead of installing another one inside Rock.
setup-java: false
variant: ${{ matrix.variant }}
rock-build-extra-params: '--extra-params -PreactNativeArchitectures=arm64-v8a,x86_64'
comment-bot: false
Loading