Skip to content

[No QA] Block compromised Java certificates in CI - #104804

Closed
roryabraham wants to merge 1 commit into
mainfrom
rory/java-certificates-rollout
Closed

roryabraham wants to merge 1 commit into
mainfrom
rory/java-certificates-rollout

Conversation

@roryabraham

Copy link
Copy Markdown
Contributor

Explanation of Change

Block the compromised eMudhra certificates before Java network operations using the shared action from Expensify/GitHub-Actions#117. Context: https://expensify.slack.com/archives/C0CAUQBC89F/p1792630445125879?thread_ts=1792538940.390139

  • Protect the selected JVM after Java/Gradle setup and cache restoration in the reusable Android build and Android artifact publisher.
  • Protect the runner JVM before the Gradle-based iOS artifact publisher.
  • Move Rock's AdoptOpenJDK 17 setup/cache restoration into the remote Android workflow, then protect it and disable Rock's nested installer so it cannot replace the protected JVM. The Java vendor/major version is preserved.
  • Reusable callers inherit protection: deploy, hybrid verification, ad-hoc/test builds, and React Native artifact publishing.

AI Tests

  • Passed: actionlint 1.17.0 on all four changed workflows with existing Blacksmith runner labels configured; embedded shell/Python checks disabled because their bodies are unchanged.
  • Passed: strict YAML parsing and ordering checks across 16 rollout jobs, including protection after setup/cache restoration and before Java commands, Rock installer suppression, and absence of root job containers.
  • Passed: npm run lint-changed, npm run spell-changed, and git diff --check.
  • Attempted: .github/scripts/verifyActions.sh; rebuilding with the existing checkout's dependencies produced local bundle drift (23 bundles differed only by symlink-relative dependency paths; two also differed with that dependency installation). All generated files were restored; no action source or bundle changes are included.
  • Native builds and publishing workflows were not run locally. The shared action fails the job if the selected JVM cannot be patched; automatically provisioned additional JDKs require their own protection.

Fixed Issues

$
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

Apply the shared eMudhra certificate blocklist after Java setup and
cache restoration, before Java network operations. Keep the selected
JVM protected when nested Android actions would otherwise replace it.

Source: Expensify/GitHub-Actions#117
@roryabraham
roryabraham requested a review from a team October 22, 2026 22:28
@roryabraham

Copy link
Copy Markdown
Contributor Author

Consolidated into #104803; retaining that draft and preserving both branches and commit history.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant