Repository navigation
[Payment due @ZhenjaHorbach] [NoQA][Wise][Release 1] Business - UI - Entry Point Workspace - #104485
Conversation
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
@ZhenjaHorbach Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
🚧 joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 79b1c6b225
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
This comment has been minimized.
This comment has been minimized.
BUG dismissing banner does not persist after signing out and back inDo we need a fix similar to https://github.com/Expensify/Auth/pull/25678 for this too @grgia ? |
|
Otherwise working well! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-21.at.13.44.37.movAndroid: mWeb ChromeScreen.Recording.2026-10-21.at.13.44.37.moviOS: HybridAppScreen.Recording.2026-10-21.at.13.17.03.moviOS: mWeb SafariScreen.Recording.2026-10-21.at.13.45.55.movMacOS: Chrome / SafariScreen.Recording.2026-10-21.at.12.55.08.mov |
|
I've addressed this comment #104366 (comment) in this PR |
|
Should we add a tooltip for close button? Screen.Recording.2026-10-21.at.12.55.42.mov |
melvin-bot
Bot
changed the title
|
🎯 @ZhenjaHorbach, thanks for reviewing and testing this PR! 🎉 A payment issue will be created for your review once this PR is deployed to production. If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created. |
| CHANGE_POLICY_TRAINING_MODAL: 'changePolicyModal', | ||
| AGENTS_RULES_BANNER: 'agentsRulesBanner', | ||
| WISE_GLOBAL_REIMBURSEMENTS_WALLET_BANNER: 'wiseGlobalReimbursementsWalletBanner', | ||
| WISE_GLOBAL_REIMBURSEMENTS_WORKSPACE_BANNER: 'wiseGlobalReimbursementsWorkspaceBanner', |
There was a problem hiding this comment.
lol sob this needs auth change too
grgia
left a comment
grgia
left a comment
There was a problem hiding this comment.
NOTE: Auth PR pending for NVP - https://github.com/Expensify/Auth/pull/25722
|
🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.16-0 🚀
|
|
No help site update is needed. The Wise global reimbursements banner and intro page in Workflows > Payments and Wallet only appear behind the |
|
🚀 Deployed to staging by https://github.com/grgia in version: 9.5.18-0 🚀
|
|
No help site update is needed. The new "Pay people worldwide" banner and the Wise global reimbursements intro page are gated behind the |
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Behind the
wiseReimbursementsbeta, adds a dismissible "Pay people worldwide" banner to Workspace > Workflows > Payments for admins whose reimbursement bank account is eligible for Wise. Banner UI is shared with Wallet viaWiseGlobalReimbursementsBanner. The intro page now opens via aglobal-reimbursements/:bankAccountIDdynamic route from both entry points.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/692501
PROPOSAL:
Tests
Test 1 - Workspace banner and intro page
wiseReimbursementsbeta enabled, on a workspace that reimburses via Expensify from a verified (OPEN) USD business bank account shared with you/global-reimbursements/<bankAccountID>, and the header says "Global reimbursements"Test 2 - Wallet entry point and old deep link
settings/wallet/global-reimbursements/<bankAccountID>, and "Not now" returns to Wallet/settings/wallet/<bankAccountID>/global-reimbursementsdirectly in the address barTest 3 - Hidden when not eligible
wiseReimbursementsbeta is disabledOffline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-10-20.at.17.05.42.mov