[CP Staging] Do not restrict toggle height by s77rt · Pull Request #104427 · Expensify/App

s77rt · 2026-10-20T00:10:27Z

Explanation of Change

The ToggleSettingsOptionRow had a fixed height of 40px and when the text is too long it would overlap (needs more than 40px). In Web the text just overflows (this was not noticeable) but in native the text is cut. This PR fixes that by making the 40px the min height and not a fixed height.

Fixed Issues

$ #104403
PROPOSAL:

Tests

Precondition:

Having a Control WS or create one

Launch Expensify App
Log in with valid credentials
Navigate to Workspace > Workflows > Advance
Verify the "Prevent marking non-reimbursable reports as paid" toggle title is fully rendered

Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

melvin-bot · 2026-10-20T00:10:47Z

@FitseTLT Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-20T00:10:50Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-20T00:21:11.502646Z	`92743b2`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

github-actions · 2026-10-20T08:02:31Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

grgia · 2026-10-20T11:26:25Z

@FitseTLT would you prioritize review for this blocker?

FitseTLT · 2026-10-20T12:02:46Z

Reviewing

FitseTLT · 2026-10-20T13:13:10Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

FitseTLT · 2026-10-20T13:13:59Z

@Expensify/design Anyone available to approve from the snapshots above.

dannymcclain · 2026-10-20T13:52:49Z

Screenshots look good 👍

github-actions · 2026-10-20T15:08:01Z

🚧 grgia has triggered a test Expensify/App build. You can view the workflow run here.

OSBotify · 2026-10-20T15:13:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-20T15:13:34Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104427.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-1be0884-bbab4b1-e5e26271d2ebdf9eb64d27648b171cbbd877c558/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-1be0884-bbab4b1-e0d9b12b960c416dd6c91a750dc324c318292897/index.html

Web 🕸️
https://104427.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

[CP Staging] Do not restrict toggle height (cherry picked from commit 1be0884) (cherry-picked to staging by grgia)

OSBotify · 2026-10-20T16:07:37Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.5.14-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-20T16:12:15Z

No help site update needed: this PR only changes the toggle row's fixed height to a minimum height, so long titles stop getting cut off. The labels and behavior that articles describe stay the same.

view run

IuliiaHerets · 2026-10-20T16:55:10Z

@s77rt CP was passed by QA team on Android and iOS, 9.5.14-3

cc @grgia

1792514577448.Prevent_toggle.1.mp4

1792515147043.PR_104427.mp4

OSBotify · 2026-10-20T19:20:14Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.14-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

OSBotify · 2026-10-20T19:43:36Z

🚀 Cherry-picked to staging by https://github.com/grgia in version: 9.5.15-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-20T19:47:38Z

No help site update needed: this PR only changes the toggle row's fixed height to a minimum height, so long titles stop getting cut off. No feature, label, or workflow that an article describes has changed.

view run

OSBotify · 2026-10-21T19:32:26Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

do not restrict toggle height

92743b2

s77rt marked this pull request as ready for review October 20, 2026 00:10

s77rt requested review from a team as code owners October 20, 2026 00:10

melvin-bot Bot requested review from FitseTLT and removed request for a team October 20, 2026 00:10

melvin-bot Bot requested review from dylanexpensify and removed request for a team October 20, 2026 00:10

melvin-bot Bot assigned s77rt Oct 20, 2026

s77rt mentioned this pull request Oct 20, 2026

[Due for payment 2026-10-27] Android & iOS - Workflows - Missing and cut off workflows title #104403

Closed

2 of 7 tasks

grgia changed the title ~~Do not restrict toggle height~~ [CP Staging] Do not restrict toggle height Oct 20, 2026

grgia approved these changes Oct 20, 2026

View reviewed changes

This comment has been minimized.

Sign in to view

FitseTLT approved these changes Oct 20, 2026

View reviewed changes

melvin-bot Bot requested a review from stitesExpensify October 20, 2026 13:53

grgia merged commit 1be0884 into Expensify:main Oct 20, 2026
43 of 45 checks passed

OSBotify pushed a commit that referenced this pull request Oct 20, 2026

Merge pull request #104427 from s77rt/toggle-fix-height

d931ac3

[CP Staging] Do not restrict toggle height (cherry picked from commit 1be0884) (cherry-picked to staging by grgia)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 20, 2026

OSBotify mentioned this pull request Oct 20, 2026

Deploy Checklist: New Expensify 2026-10-19 #104377

Closed

74 tasks done

Conversation

s77rt commented Oct 20, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 20, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

This comment has been minimized.

grgia commented Oct 20, 2026

Uh oh!

FitseTLT commented Oct 20, 2026

Uh oh!

FitseTLT commented Oct 20, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

FitseTLT commented Oct 20, 2026

Uh oh!

dannymcclain commented Oct 20, 2026

Uh oh!

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

github-actions Bot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

MelvinBot commented Oct 20, 2026

Uh oh!

IuliiaHerets commented Oct 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 20, 2026

Uh oh!

MelvinBot commented Oct 20, 2026

Uh oh!

OSBotify commented Oct 21, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chatgpt-codex-connector Bot commented Oct 20, 2026 •

edited

Loading

IuliiaHerets commented Oct 20, 2026 •

edited

Loading