You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
[Due for payment 2026-10-27] Android & iOS - Workflows - Missing and cut off workflows title #104403
Version Number: 9.5.14-0 Reproducible in staging?: Yes Reproducible in production?: N/A - new feature, doesn't exist in prod If this was caught during regression testing, add the test name, ID and link from BrowserStack:#100569 Email or phone of affected tester (no customers):[email protected] Issue reported by: Applause Internal Team Bug source: Pull Request QA execution Device used: Samsung Galaxy S21/Android 15, iPhone 13/18.6.2 App Component: Other
Action Performed:
Precondition:
Having a Control WS or create one
Launch Expensify App
Log in with valid credentials
Navigate to Workspace > Workflows > Advance
Expected Result:
All option's title are complete and can be read entire
Actual Result:
The title option "Prevent marking non-reimbursable reports as paid" is incomplete in Android showing only "Prevent marking" and in iOS is cut off showing: "Prevent marking non-reimbursable rep" preventing user to read completly
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
Identify the pull request that introduced this issue and revert it.
Root cause: The toggle row gives the title-and-switch area a fixed height of 40px whenever shouldPlaceSubtitleBelowSwitch is set (ToggleSettingsOptionRow.tsx:282). After the pv2 padding, only one 20px line fits. The new "Prevent marking non-reimbursable reports as paid" title is the first in this section long enough to wrap on a phone, so Android and iOS clip it.
Recommendation: fix forward, don't revert. At ToggleSettingsOptionRow.tsx:282, change styles.h10 to styles.mnh40 (minimum height 40px). Single-line rows keep the same height, and long titles can wrap. If the fix can't land in time, revert #100569.
The fixed h10 was there before this PR. The PR just added the first title too long for it. The other titles in the section ("Prevent self-approvals", "Auto-pay approved reports") fit on one line.
About 96 call sites use shouldPlaceSubtitleBelowSwitch. Only rows whose titles overflow today would change.
Alternative: if you'd rather not touch the shared component, override the height for this section through toggleContainerStyles (height: 'auto' plus mnh40), which is applied after h10.
I didn't recommend a revert because it would remove the whole feature (API, Onyx, report actions, tests) to fix a one-line layout bug.
Not tested: on wide desktop web the title fits on one line, so this likely doesn't show there.
changed the title [-]Android & iOS - Workflows - Missing and cut off workflows title[/-][+][Due for payment 2026-10-27] Android & iOS - Workflows - Missing and cut off workflows title[/+]on Oct 20, 2026
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.14-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
Activity
applause-bot commentedon Oct 19, 2026
While Applause doesn't embed attachments for this bug, here are the links for quick view:
https://platform.applause.com/services/links/v1/external/bb8b57f676be502e9eec17cb2806fac1246b711a4bf08ba46430e0736056bb0c
https://platform.applause.com/services/links/v1/external/52ab43cb47a2b9cc31b2196a58dfdfce79503359d89a6b5db585480f9df0a539
melvin-bot commentedon Oct 19, 2026
You have been assigned to this deploy blocker because you recently merged this PR: #100569
melvin-bot commentedon Oct 19, 2026
@stitesExpensify @FitseTLT you have been assigned to this deploy blocker because you reviewed the offending PR: #100569
github-actions commentedon Oct 19, 2026
👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
melvin-bot commentedon Oct 19, 2026
@s77rt you have been assigned to this deploy blocker because you authored the offending PR: #100569
melvin-bot commentedon Oct 19, 2026
💬 A slack conversation has been started in #expensify-open-source
MelvinBot commentedon Oct 19, 2026
Deploy Blocker Analysis
Causing PR: Add workspace setting to control marking non-reimbursable reports as paid (
Expensify/App#100569). It's a frontend bug and I'm highly confident in this.Root cause: The toggle row gives the title-and-switch area a fixed height of 40px whenever
shouldPlaceSubtitleBelowSwitchis set (ToggleSettingsOptionRow.tsx:282). After thepv2padding, only one 20px line fits. The new "Prevent marking non-reimbursable reports as paid" title is the first in this section long enough to wrap on a phone, so Android and iOS clip it.Recommendation: fix forward, don't revert. At ToggleSettingsOptionRow.tsx:282, change
styles.h10tostyles.mnh40(minimum height 40px). Single-line rows keep the same height, and long titles can wrap. If the fix can't land in time, revert #100569.Investigation details
shouldPlaceSubtitleBelowSwitchandtitleStyle={styles.pv2}(ExpenseReportRulesSection.tsx:225-226).lh20(ToggleSettingsOptionRow.tsx:224-229). NonumberOfLinesis set, so the fixed parent height is what clips it.h10was there before this PR. The PR just added the first title too long for it. The other titles in the section ("Prevent self-approvals", "Auto-pay approved reports") fit on one line.shouldPlaceSubtitleBelowSwitch. Only rows whose titles overflow today would change.toggleContainerStyles(height: 'auto'plusmnh40), which is applied afterh10.view run
s77rt commentedon Oct 20, 2026
Update: Raised PR.
IuliiaHerets commentedon Oct 20, 2026
Issue is no longer reproduced, comment here
[-]Android & iOS - Workflows - Missing and cut off workflows title[/-][+][Due for payment 2026-10-27] Android & iOS - Workflows - Missing and cut off workflows title[/+]melvin-bot commentedon Oct 20, 2026
@FitseTLT
The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.14-3 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:
If no regressions arise, payment will be issued on 2026-10-27. 🎊
The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the Contributor+ Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]. If no checklist is needed for this issue, you can click: [no checklist button]
melvin-bot commentedon Oct 23, 2026
@FitseTLT Whoops! This issue is 2 days overdue. Let's get this updated quick!