Repository navigation
[No QA] Docs updates for E/A#103309 Add declined search operator for rejected expenses and reports - #104383
Conversation
Co-authored-by: Krishna Chaitanya <[email protected]>
|
I created this PR from an upstream branch since I don't have push access to your fork. To take ownership of this branch and be able to push updates, run: Then you can close this PR and open a new one from your fork. |
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot resolve the conflicts |
…archFilter Co-authored-by: Krishna Chaitanya <[email protected]> # Conflicts: # docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md
|
I resolved the merge conflict by merging The only conflict was the |
|
A preview of your ExpensifyHelp changes have been deployed to https://b3bbe9b0.helpdot.pages.dev ⚡️ Updated articles: |
|
@MelvinBot mark this PR as ready for review |
|
I marked this PR as ready for review. It has no merge conflicts with |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
@joekaufmanexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, well-scoped documentation update to Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.20-0 🚀
|
Explanation of Change
New feature: [Payment due
@QichenZhu] Add Rejected search filter for expenses and expense reports added a Rejected Yes/No filter for expenses and reports, with the search query keydeclined:yes/declined:no. The filter isn't behind a beta, so it's available to all users.This PR adds a
declined:row to the expense and report operator tables in Use Search Operators to Filter and Analyze, next to the similarbillable:andpaid-status:rows. It also adds "rejected filter" and "declined" to the article keywords. The UI label Rejected was verified againstsrc/languages/en.ts.@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #103309
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari