Skip to content

[No QA] Docs updates for E/A#103309 Add declined search operator for rejected expenses and reports - #104383

Merged
stephanieelliott merged 2 commits into
mainfrom
claude-docsRejectedSearchFilter
Oct 22, 2026
Merged

stephanieelliott merged 2 commits into
mainfrom
claude-docsRejectedSearchFilter

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

New feature: [Payment due @QichenZhu] Add Rejected search filter for expenses and expense reports added a Rejected Yes/No filter for expenses and reports, with the search query key declined:yes / declined:no. The filter isn't behind a beta, so it's available to all users.

This PR adds a declined: row to the expense and report operator tables in Use Search Operators to Filter and Analyze, next to the similar billable: and paid-status: rows. It also adds "rejected filter" and "declined" to the article keywords. The UI label Rejected was verified against src/languages/en.ts.

@c3024, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #103309
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot
MelvinBot requested a review from a team October 19, 2026 18:00
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 19, 2026
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I created this PR from an upstream branch since I don't have push access to your fork.

To take ownership of this branch and be able to push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-docsRejectedSearchFilter
git checkout -b claude-docsRejectedSearchFilter upstream/claude-docsRejectedSearchFilter
git push -u origin claude-docsRejectedSearchFilter

Then you can close this PR and open a new one from your fork.

@github-actions github-actions Bot changed the title Docs updates for E/A#103309 Add declined search operator for rejected expenses and reports [No QA] Docs updates for E/A#103309 Add declined search operator for rejected expenses and reports Oct 19, 2026
@OSBotify

This comment has been minimized.

@c3024

c3024 commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

@MelvinBot resolve the conflicts

…archFilter

Co-authored-by: Krishna Chaitanya <[email protected]>

# Conflicts:
#	docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I resolved the merge conflict by merging main into this branch and pushed the merge commit (655d604).

The only conflict was the keywords front-matter line in Use-Search-Operators-to-Filter-and-Analyze.md. I kept both sides: vendor filter from main, plus this PR's rejected filter and declined. Both declined: table rows merged automatically. The PR diff against main still shows only those three changes.


view run

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://b3bbe9b0.helpdot.pages.dev ⚡️

Updated articles:

@c3024 c3024 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QichenZhu

Copy link
Copy Markdown
Contributor

@MelvinBot mark this PR as ready for review

@MelvinBot
MelvinBot marked this pull request as ready for review October 20, 2026 08:25
@MelvinBot

Copy link
Copy Markdown
Contributor Author

I marked this PR as ready for review. It has no merge conflicts with main.


view run

@melvin-bot

melvin-bot Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Product reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR?

cc @joekaufmanexpensify

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-20T08:28:06.861855Z 655d604 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@melvin-bot
melvin-bot Bot requested review from joekaufmanexpensify and removed request for a team October 20, 2026 08:25
@melvin-bot

melvin-bot Bot commented Oct 20, 2026

Copy link
Copy Markdown

@joekaufmanexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR makes a small, well-scoped documentation update to Use-Search-Operators-to-Filter-and-Analyze.md. It adds a declined: operator row to both the expense and report filter tables (documenting the new Rejected Yes/No filter) and appends rejected filter and declined to the article keywords. The additions slot cleanly into the existing operator tables next to similar rows like billable: and paid-status:, matching the established format and tone.

Scores Summary

  • Readability: 9/10 - New rows follow the exact Syntax | Description | Example pattern of the surrounding table. Descriptions are concise, action-oriented, and consistent with neighboring entries.
  • AI Readiness: 9/10 - Keyword additions (rejected filter, declined) reflect real search intent and improve retrieval. The changes sit under existing task-based ## headings; no new headings or structure introduced, so single-# and heading-hierarchy rules remain satisfied.
  • Style Compliance: 9/10 - The UI label Rejected is correctly bolded, in sentence case, and verified against src/languages/en.ts. Operator values (yes/no) are in backticks consistent with the rest of the tables. Generic terms (expense, report) are lowercased correctly.

Key Findings

  • Positive: Changes are minimal, consistent, and placed logically beside analogous boolean operators (billable:, reimbursable:, paid-status:).
  • Positive: The Rejected UI label is bolded and matches the product UI, satisfying the label naming standards.
  • Positive: Keyword additions align with search intent without bloating the metadata.
  • Minor: The two new description cells omit a trailing period ("Matches the Rejected filter"), whereas some neighboring rows end with full sentences and periods. Cosmetic and already inconsistent in the existing table, so not blocking.

Recommendations

  • Optional: Add a trailing period to "Matches the Rejected filter." for consistency with full-sentence descriptions in the same tables.
  • No structural, navigation, or terminology changes required. The diff is compliant and ready.

Files Reviewed

  • docs/articles/new-expensify/reports-and-expenses/Use-Search-Operators-to-Filter-and-Analyze.md - Compliant. Two operator rows and two keywords added; follows governance standards.

Note: Detailed line-by-line feedback has been provided as inline comments.

@joekaufmanexpensify joekaufmanexpensify left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanieelliott
stephanieelliott merged commit 6d7fe90 into main Oct 22, 2026
30 of 32 checks passed
@stephanieelliott
stephanieelliott deleted the claude-docsRejectedSearchFilter branch October 22, 2026 02:00
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.20-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants