[Payment due @QichenZhu] Add Rejected search filter for expenses and expense reports by c3024 · Pull Request #103309 · Expensify/App

c3024 · 2026-10-07T10:29:03Z

Explanation of Change

Adds a "Rejected" Yes/No filter for expenses and expense reports. The query key is declined:yes / declined:no. It works like Billable: filter list page, filter bar chip, typed query with autocomplete and negation.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/685831
PROPOSAL:

Tests

As a submitter on a workspace with approvals, submit three reports to an approver.
As the approver, reject one expense on the first report.
As the approver, reject the whole second report.
As the submitter, go to Spend > Expenses and click Filters.
Verify Rejected appears below Billable.
Select Rejected > Yes.
Verify a "Rejected: Yes" chip appears and only the rejected expense is listed.
Change the chip to No.
Verify the rejected expense is not listed and the other expenses are.
Go to Spend > Reports and click Filters.
Verify Rejected appears below Paid status.
Select Rejected > Yes.
Verify only the second report is listed.
Click the search icon and type declined:.
Verify the suggestions are declined:no and declined:yes.
Search for type:expense -declined:yes.
Verify the rejected expense is not listed.

Verify that no errors appear in the JS console

Offline tests

Go offline.
Click Filters on Spend > Expenses and select Rejected > Yes.
Verify the "Rejected: Yes" chip appears.
Go online.
Verify the results load and show only rejected expenses.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

685831-stg-05-admin-expenses-declined-yes

685831-stg-06-admin-reports-declined-yes

685831-stg-12-router-declined-yes-result

685831-stg-14-submitter-expenses-declined-yes

685831-stg-15-submitter-expenses-declined-no

685831-stg-16-submitter-expenses-negated-yes

685831-stg-17-submitter-reports-declined-yes

melvin-bot · 2026-10-07T10:29:30Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

codecov · 2026-10-07T10:33:07Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`95.90% <ø> (ø)`
...ents/Search/FilterComponents/ListFilterContent.tsx	`10.52% <ø> (ø)`
src/hooks/useAdvancedSearchFilters.ts	`97.29% <ø> (ø)`
src/hooks/useAutocompleteSuggestions.ts	`73.07% <ø> (ø)`
src/libs/SearchParser/autocompleteParser.js	`59.93% <ø> (+0.10%)`	⬆️
src/libs/SearchParser/searchParser.js	`85.65% <ø> (+0.06%)`	⬆️
src/libs/SearchQueryUtils.ts	`91.01% <100.00%> (+0.13%)`	⬆️
src/types/form/SearchAdvancedFiltersForm.ts	`100.00% <ø> (ø)`
src/libs/SearchAutocompleteUtils.ts	`62.87% <0.00%> (-0.32%)`	⬇️
src/libs/SearchUIUtils.ts	`73.54% <87.50%> (+0.12%)`	⬆️
... and 7 files with indirect coverage changes

…cted-search-filter # Conflicts: # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/searchParser.js

melvin-bot · 2026-10-15T09:57:16Z

@QichenZhu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

chatgpt-codex-connector · 2026-10-15T09:57:20Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-10-16T18:08:15.563193Z	`b40435f`	New commits

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb243dfbfe

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2026-10-15T10:13:19Z

    }

-    if (key === FILTER_KEYS.BILLABLE || key === FILTER_KEYS.REIMBURSABLE) {
+    if (key === FILTER_KEYS.BILLABLE || key === FILTER_KEYS.REIMBURSABLE || key === FILTER_KEYS.DECLINED) {


Translate negated Rejected filter values

When a user enters a negated query such as -declined:yes, buildFilterFormValuesFromQuery() stores the value under declinedNot, so this positive-only condition is skipped and the generic fallback returns the raw syntax token. As a result, filter chips and saved-search summaries show lowercase English yes/no (including in non-English locales) instead of the localized common.yes/common.no used for declined; handle DECLINED_NOT in the translated boolean branch as well.

Useful? React with 👍 / 👎.

This comment seems valid.

However, it's an existing issue. For example, the billable filter.

Fixed in 83d1cac. Negated Billable, Reimbursable and Rejected chips now show the translated Yes/No.

…cted-search-filter

QichenZhu · 2026-10-15T12:03:45Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
https://expensify.slack.com/archives/C049HHMV9SM/p1764642854883869
I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
Checking this off based on the author's checklist. I can't verify it since I don't have access to the internal issue.
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-native.webm

Android: mWeb Chrome

android-web.webm

iOS: HybridApp

ios-native.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

mac-web.mov

QichenZhu · 2026-10-15T12:04:05Z

NAB: The Rejected filter can't set negated or not. The Billable and Reimbursable filters have the same issue, but the Currency filter can.

nab.mov

c3024 · 2026-10-15T12:32:04Z

Thanks. I don’t think it makes much sense to have Is/Is Not for booleans, so the existing design looks fine to me. Similarly, -declined:yes doesn’t seem particularly useful when it can be expressed as declined:no. However, it already exists and is only accessible by typing it manually.

QichenZhu · 2026-10-15T12:58:59Z

@MelvinBot please review this PR for accessibility issues.

QichenZhu · 2026-10-15T13:07:57Z

VoiceOver announces the "Rejected" menu as "declined, group" and it's not translated. The "Yes" and "No" options are not reachable.

voiceover.mov

MelvinBot · 2026-10-15T13:08:19Z

Accessibility review

No blocking accessibility problems. The Rejected filter reuses existing components that already work with screen readers, and all 11 locales have the new label. Two inherited issues are more noticeable on this filter. Consider fixing them here or in a follow-up.

The filters list row is announced as "declined", but the screen shows "Rejected". FilterList.tsx:79 sets accessibilityLabel={filterKey} (the raw query key), not the translated text on line 97. This breaks WCAG 2.5.3 (Label in Name): saying "click Rejected" in voice control won't activate the row. It affects every row, but this row has the biggest gap. Fix: use accessibilityLabel={translate(labelKey)} and add role={CONST.ROLE.BUTTON}.
A negated value is hidden or unclear. If someone types -declined:yes:
- The chip reads "-Rejected: Yes". The negation is just a hyphen (SearchUIUtils.ts:6142), which screen readers often skip or read as "dash".
- The popup shows "Yes" selected with no hint of negation. Applying it keeps the hidden negation (ListPopup.tsx:25-30). That's because declined isn't in NEGATABLE_FILTER_KEYS, so no Is/Is not toggle appears.
Billable and Reimbursable already behave this way. A simple fix for booleans is to turn -declined:yes into declined:no when the query is parsed. That would also cover the NAB above.

Checked and fine

ThumbsDown icon: a registered icon. It renders without a label, so Icon hides it from screen readers.
Yes/No list: each row has role="option" and a selected state, so screen readers announce "Yes, selected". The radio indicator isn't a separate tab stop.
Translations: search.filters.rejected is in all locale files. No hard-coded strings.
Focus order: no new focusable elements. The row follows the visible order (after Billable on Expenses, after Paid status on Reports).
getDisplayValue _NOT change: an improvement. Before, negated Billable and Reimbursable chips showed a raw, untranslated yes.
Autocomplete: suggestions read "declined:yes", like "billable:yes". Typing rej… won't find the filter. That's about discoverability, not accessibility.
Other inherited gaps outside this diff: the chip's close (×) button has no accessible name (DropdownButton.tsx:104-116), and the Yes/No list has no accessible name.

This review is based on reading the code. I didn't run a screen reader.

QichenZhu

Deferring to the internal team on whether we should handle the accessibility issues here or separately.

melvin-bot · 2026-10-15T14:07:26Z

🎯 @QichenZhu, thanks for reviewing and testing this PR! 🎉

A payment issue will be created for your review once this PR is deployed to production.
E/E issue linked to the PR - https://www.github.com/Expensify/Expensify/issues/685831.

If payment is not needed (e.g., regression PR review fix etc), react with 👎 to this comment to prevent the payment issue from being created.

JS00001

Since we are adding a new filter, we need to follow our pattern of also creating a new column, and allowing that column to be sorted by

joekaufmanexpensify

Good for product

c3024 · 2026-10-16T06:43:14Z

@JS00001

Thanks. We implemented only the filter on the backend so far. The column needs backend work first, because the search response has no rejected value per expense or report, and sorting needs a new sortBy:declined with its own query timings. Can I ship the filter here and do the column and sort as a follow-up? I'll open the Auth PR for the response field and sort, then an App PR for the column.

JS00001 · 2026-10-16T12:10:55Z

yeah, @c3024 lets make sure we do a follow up to add the col to export, and sorting

JS00001 · 2026-10-16T12:13:42Z

@QichenZhu for #103309 (comment), the 'declined' is fine for now, do other filters allow you to reach yes/no?

QichenZhu · 2026-10-16T17:40:36Z

do other filters allow you to reach yes/no?

The other filters have the same issue.

QichenZhu · 2026-10-16T17:41:06Z

@c3024 please resolve conflicts.

JS00001 · 2026-10-16T17:46:29Z

@c3024 conflicts

…cted-search-filter # Conflicts: # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/searchParser.js

c3024 · 2026-10-16T18:00:44Z

conflicts fixed.

github-actions · 2026-10-16T18:14:38Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-16T18:19:53Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #103309.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-63b63cd-ba14948-509ed155cf4e1ea3af11a598d4b7a8bc11db1994/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-63b63cd-ba14948-b95dfb41f34d5aed03b8f7f7f4cd6dba5c884447/index.html

Web 🕸️
https://103309.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-16T18:23:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-10-19T17:52:48Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.14-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-19T18:00:47Z

A help site update is needed. I opened a draft docs PR: Docs updates for E/A#103309 Add declined search operator for rejected expenses and reports

This PR adds a new Rejected filter for all users (not beta-gated), so it counts as a new feature. The edit adds a declined: row to the expense and report tables in Use Search Operators to Filter and Analyze, next to the similar billable: and paid-status: rows.

@c3024, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

OSBotify · 2026-10-20T19:17:44Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.14-3 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

melvin-bot · 2026-10-20T19:21:05Z

🤖 Payment issue created: #104496

Add Rejected (declined:) search filter for expenses and expense reports

1cc1f6f

melvin-bot Bot assigned c3024 Oct 7, 2026

Merge remote-tracking branch 'origin/main' into chaitanya/685831-reje…

fb243df

…cted-search-filter # Conflicts: # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/searchParser.js

c3024 marked this pull request as ready for review October 15, 2026 09:57

c3024 requested review from a team as code owners October 15, 2026 09:57

melvin-bot Bot requested review from QichenZhu and joekaufmanexpensify and removed request for a team October 15, 2026 09:57

melvin-bot Bot removed the request for review from a team October 15, 2026 09:57

chatgpt-codex-connector Bot reviewed Oct 15, 2026

View reviewed changes

c3024 added 2 commits October 15, 2026 16:47

Translate negated yes/no filter values in search filter labels

83d1cac

Merge remote-tracking branch 'origin/main' into chaitanya/685831-reje…

6d3edf1

…cted-search-filter

QichenZhu approved these changes Oct 15, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 October 15, 2026 14:07

melvin-bot Bot changed the title ~~Add Rejected search filter for expenses and expense reports~~ [Payment due @QichenZhu] Add Rejected search filter for expenses and expense reports Oct 15, 2026

JS00001 requested changes Oct 15, 2026

View reviewed changes

joekaufmanexpensify previously approved these changes Oct 15, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into chaitanya/685831-reje…

b40435f

…cted-search-filter # Conflicts: # src/libs/SearchParser/autocompleteParser.js # src/libs/SearchParser/searchParser.js

c3024 dismissed joekaufmanexpensify’s stale review via b40435f October 16, 2026 17:54

JS00001 approved these changes Oct 16, 2026

View reviewed changes

JS00001 merged commit 63b63cd into Expensify:main Oct 16, 2026
51 of 72 checks passed

OSBotify mentioned this pull request Oct 19, 2026

Deploy Checklist: New Expensify 2026-10-19 #104377

Closed

74 tasks done

MelvinBot mentioned this pull request Oct 19, 2026

[No QA] Docs updates for E/A#103309 Add declined search operator for rejected expenses and reports #104383

Merged

38 tasks

applause-bot Bot mentioned this pull request Oct 19, 2026

No suggestions when type declined: on search #104399

Closed

1 of 7 tasks

This was referenced Oct 20, 2026

[$175] Add a "Rejected" and a "Held" suggested search that appears once a user has rejected/held expenses #103339

Open

Add a Rejected suggested search that appears once the user has a rejected expense #104438

Draft

melvin-bot Bot mentioned this pull request Oct 20, 2026

[Due for payment 2026-10-27] Payment issue for E/App PR#103309 #104496

Open

c3024 mentioned this pull request Oct 21, 2026

[HOLD Auth 25720] Add a sortable Rejected column to Search #104566

Draft

38 tasks done

Conversation

c3024 commented Oct 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot Bot commented Oct 7, 2026

Uh oh!

codecov Bot commented Oct 7, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot Bot commented Oct 15, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

QichenZhu Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

c3024 Oct 15, 2026

Choose a reason for hiding this comment

Uh oh!

QichenZhu commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

QichenZhu commented Oct 15, 2026

Uh oh!

c3024 commented Oct 15, 2026

Uh oh!

QichenZhu commented Oct 15, 2026

Uh oh!

QichenZhu commented Oct 15, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Oct 15, 2026

Accessibility review

Uh oh!

QichenZhu left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot Bot commented Oct 15, 2026

Uh oh!

JS00001 left a comment

Choose a reason for hiding this comment

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

c3024 commented Oct 16, 2026

Uh oh!

JS00001 commented Oct 16, 2026

Uh oh!

JS00001 commented Oct 16, 2026

Uh oh!

QichenZhu commented Oct 16, 2026

Uh oh!

QichenZhu commented Oct 16, 2026

Uh oh!

JS00001 commented Oct 16, 2026

Uh oh!

c3024 commented Oct 16, 2026

Uh oh!

Uh oh!

c3024 commented Oct 7, 2026 •

edited

Loading

codecov Bot commented Oct 7, 2026 •

edited by github-actions Bot

Loading

chatgpt-codex-connector Bot commented Oct 15, 2026 •

edited

Loading

QichenZhu Oct 15, 2026 •

edited

Loading

QichenZhu commented Oct 15, 2026 •

edited

Loading

QichenZhu commented Oct 15, 2026 •

edited

Loading