Show Per Diem Download CSV option before rates are added by MelvinBot · Pull Request #104252 · Expensify/App

MelvinBot · 2026-10-16T15:57:55Z

Explanation of Change

The "Download CSV" option in the Per Diem page's "More" menu was only shown once the workspace had at least one rate. Admins use that download to get the import template with the right headers, so they need it before adding rates (Classic already allows this).

This PR shows "Download CSV" when the workspace has rates or the user can edit Per Diem (canWritePerDiem). Read-only members keep the old behavior, since an empty template isn't useful to someone who can't import.

Fixed Issues

$ #104175
PROPOSAL: #104175 (comment)

Tests

Precondition: Use the staging API (not production).

Go to a workspace > More features > Enable Per diem(Workspace should not have per diem rates - just enabled section)
Go to workspace > Per Diem
Click "More"
Make sure "Download CSV" option is present and works correctly

Verify that no errors appear in the JS console

Offline tests

Go to a workspace > More features > Enable Per diem(Workspace should not have per diem rates - just enabled section)
Go to workspace > Per Diem
Click "More"
Make sure "Download CSV" option is present (In offline mode you can't download so "You appear to be offline" modal appears)

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

…n grab the import template Co-authored-by: Eskalifer1 <[email protected]>

MelvinBot · 2026-10-16T15:58:15Z

I created this PR from an upstream branch because I don't have push access to your fork.

To take ownership of this branch and push updates, run:

git remote add upstream https://github.com/Expensify/App.git
git fetch upstream claude-perDiemDownloadCsvBeforeRates
git checkout -b claude-perDiemDownloadCsvBeforeRates upstream/claude-perDiemDownloadCsvBeforeRates
git push -u origin claude-perDiemDownloadCsvBeforeRates

Then you can close this PR and open a new one from your fork.

Eskalifer1 · 2026-10-16T15:59:04Z

@codex review

chatgpt-codex-connector · 2026-10-16T15:59:17Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	🔄 Running since 2026-10-21T10:45:18.568040Z	`73ca0ef`	Draft marked ready

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

MelvinBot · 2026-10-16T15:59:39Z

⚠️ A setup step failed before I could start. This is usually a temporary issue — try again in a few minutes, and if it persists post in #melvinbot-ai.

Run details

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8af1e0fe71

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

chatgpt-codex-connector · 2026-10-16T16:01:47Z

+        if (hasVisibleSubRates || canWritePerDiem) {
            menuItems.push({


Gate the empty-template action on backend support

When an admin has no Per Diem rates, this new condition exposes the download action, but downloadPerDiemCSV() calls ExportPerDiemCSV, which currently rejects that exact case with “No rates found to be exported.” Consequently, the newly enabled action always ends in the download-failed modal and cannot provide the promised import template. This change should be coordinated with the backend support or otherwise generate/provide a valid empty template.

Useful? React with 👍 / 👎.

@MelvinBot What do you think about that?

Seems like we are wating on BE PR to be deployed: #104175 (comment)

Should we make any action here?

No code change is needed. The Codex finding is valid, but the backend PR already fixes it, so the frontend should not work around it.

I recommend these steps:

Keep this PR in draft, or mark it on hold, until the backend PR deploys. If it merges first, admins on empty workspaces get the "Download failed" modal.

After the backend PR deploys, retest on a workspace with no rates. Clicking "Download CSV" should download a header-only CSV.

Fill in the Tests and QA sections, then mark the PR ready for review.

Building the template in the frontend would duplicate the backend's CSV format and could drift from it, so I don't recommend it.

view run

MelvinBot · 2026-10-16T16:09:37Z

🤖 Web test steps verification results: ✅ pass

On a workspace with Per Diem enabled but no rates, the "More" menu now shows "Download CSV" next to "Import spreadsheet". Clicking it shows the expected "Download failed" modal until the backend fix ships. The PR has no Tests section yet, so I used the reproduction steps from the linked issue.

Step	Status
Go to a workspace you are admin of and open its settings Opened Settings > Overview for the test user's workspace (user is owner/admin).	✅
Enable Per Diem and open the Per Diem page; confirm it shows no rates Per Diem required upgrading the workspace to Control. After enabling it in More features, the Per Diem page showed the empty state with only an "Import spreadsheet" button and no rates.	✅
Click "More"; confirm the menu contains "Download CSV" The menu listed Settings, Import spreadsheet, and Download CSV with zero rates.	✅
Click "Download CSV" and record what happens A "Download failed" modal appeared ("Your download couldn't be completed. Please try again later."). This matches the known backend behavior for workspaces with no rates. No console errors.	✅

view run · view recording

MelvinBot · 2026-10-16T16:11:37Z

The failing checks are unrelated to this PR, so I didn't push a fix. main is currently broken, and this PR's CI picks that up when it merges with main.

typecheck and test (job 4): Both fail only in tests/actions/IOUTest/SplitTest.ts. This PR changes only src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx. On main, SplitTest.ts passes betas to CreateWorkspaceDataOptions, RequestMoneyInformation, and UpdateSplitTransactionsParams, but those types don't accept betas. These test changes came from Fix report total changing after reverting a split offline, merged today.
build (developmentDebug, false): The "Rock Remote Build - Android" step failed and left no error log. A one-file React page change is unlikely to cause this, so it looks flaky. Re-run it.
checklist and Check independent approval: These are the normal pending-review checks.

Next step: Once someone fixes SplitTest.ts on main, merge main into this branch or re-run the checks.

Evidence

tests/actions/IOUTest/SplitTest.ts(2710,13): error TS2353: 'betas' does not exist in type 'CreateWorkspaceDataOptions'.
tests/actions/IOUTest/SplitTest.ts(2731,13): error TS2353: 'betas' does not exist in type 'RequestMoneyInformation'.
tests/actions/IOUTest/SplitTest.ts(2808,17): error TS2353: 'betas' does not exist in type 'UpdateSplitTransactionsParams'.

The Jest failures are two updateSplitTransactions rollback tests in the same file, at lines 6762 and 6861.

view run

MelvinBot · 2026-10-16T16:17:11Z

I rechecked the checks and still didn't push a fix. The failures come from main, not this PR. This PR changes only src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx.

ESLint check (newly failed): src/libs/Navigation/types.ts has 4,001 lines, and the max-lines rule allows 4,000. The file has 4,001 lines on main too, and this PR doesn't touch it.
typecheck and test (job 4): These still fail in tests/actions/IOUTest/SplitTest.ts, which passes a betas property that its types don't accept. main still has this code. It came from Fix report total changing after reverting a split offline.
Android build: The remote build step failed without an error log. Re-run it.

Next step: After main is fixed, merge main into this branch or re-run the checks.

view run

MelvinBot · 2026-10-16T16:22:55Z

I checked again and didn't push a fix. Every failing check still comes from main, not this PR. As of 84dd007, main has not changed in a way that would fix them.

typecheck and test (job 4): tests/actions/IOUTest/SplitTest.ts on main still passes a betas property that its types don't accept. This came from Fix report total changing after reverting a split offline.
ESLint check: src/libs/Navigation/types.ts on main still has 4,001 lines, one more than max-lines allows.
Android build: This failed without an error log. Re-run it.

Merging main now would not help. Ask the author of the SplitTest.ts change to fix main, then merge main into this branch.

view run

Eskalifer1 · 2026-10-16T16:29:56Z

Details

Explanation of Change

The "Download CSV" option in the Per Diem page's "More" menu was only shown once the workspace had at least one rate. Admins use that download to get the import template with the right headers, so they need it before adding rates (Classic already allows this).

This PR shows "Download CSV" when the workspace has rates or the user can edit Per Diem (canWritePerDiem). Read-only members keep the old behavior, since an empty template isn't useful to someone who can't import.

Fixed Issues

$ #104175
PROPOSAL: #104175 (comment)

Tests

Go to a workspace > More features > Enable Per diem(Workspace should not have per diem rates - just enabled section)
Go to workspace > Per Diem
Click "More"
Make sure "Download CSV" option is present and works correctly

Verify that no errors appear in the JS console

Offline tests

Go to a workspace > More features > Enable Per diem(Workspace should not have per diem rates - just enabled section)
Go to workspace > Per Diem
Click "More"
Make sure "Download CSV" option is present (In offline mode you can't download so "You appear to be offline" modal appears)

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

@MelvinBot please set the PR body to the content in the details section above

MelvinBot · 2026-10-16T16:35:39Z

I didn't push a fix. Every failing check still comes from main, not this PR. This PR changes only src/pages/workspace/perDiem/WorkspacePerDiemPage.tsx.

typecheck and test (job 4): tests/actions/IOUTest/SplitTest.ts on main passes betas to types that no longer accept it.
ESLint check: src/libs/Navigation/types.ts on main has 4,001 lines, and the max-lines limit is 4,000.
Android build: The remote build step failed with no error log. It looks flaky.
checklist and Check independent approval: These wait on the PR checklist and review.

A fix for main is already open: [No QA] Fix max-lines lint, TypeScript and SplitTest failures on main. After it merges, merge main into this branch and the checks should pass. Ask me to do that merge once it lands.

view run

MelvinBot · 2026-10-16T16:36:44Z

🤖 Done. I replaced the PR body with the content inside your <details> block. I removed the outer <details> wrapper and kept everything else as you wrote it.

The new body drops the earlier note that the backend currently returns "No rates found to be exported." for workspaces with no rates. Add it back if you want reviewers to expect the "Download failed" modal.

view run

Eskalifer1 · 2026-10-19T12:39:49Z

@MelvinBot merge main

…dCsvBeforeRates Co-authored-by: Eskalifer1 <[email protected]>

MelvinBot · 2026-10-19T12:47:59Z

I merged main into this branch. There were no conflicts, and I pushed the merge commit (73ca0ef).

view run

codecov · 2026-10-19T12:52:44Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...c/pages/workspace/perDiem/WorkspacePerDiemPage.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

Eskalifer1 · 2026-10-21T10:10:26Z

@codex review

chatgpt-codex-connector · 2026-10-21T10:14:02Z

Codex Review: Didn't find any major issues. You're on a roll.

Reviewed commit: 73ca0efe44

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Eskalifer1 · 2026-10-21T10:36:19Z

@MelvinBot Let's add precondition to Tests that we should use staging API(not production)

MelvinBot · 2026-10-21T10:38:51Z

I added this precondition to the top of the Tests section in the PR description:

Precondition: Use the staging API (not production).

I left Offline tests and QA Steps unchanged. Let me know if you want the precondition there too.

view run

Eskalifer1 · 2026-10-21T10:38:53Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If the PR adds or modifies the UI:
- I asked an AI agent to review the changes for accessibility issues and addressed its findings.
- I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
- I verified all new/changed elements have meaningful accessible names and roles.
- I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

104252-android-native.mov

Android: mWeb Chrome

104252-android-web.mov

iOS: HybridApp

104252-ios-native.mov

iOS: mWeb Safari

104252-ios-web.mov

MacOS: Chrome / Safari

104252-web.mov

Eskalifer1 · 2026-10-21T10:39:11Z

@codex review

Eskalifer1 · 2026-10-21T10:43:02Z

@MelvinBot Mark this PR as ready for review

MelvinBot · 2026-10-21T10:45:09Z

I marked this PR as ready for review.

view run

melvin-bot · 2026-10-21T10:45:11Z

@Eskalifer1 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Eskalifer1

LGTM!

OSBotify · 2026-10-21T12:54:51Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

github-actions · 2026-10-21T12:56:12Z

🚧 JS00001 has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2026-10-21T13:01:04Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
Built from App PR #104252.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-android-Adhoc-aedd78c-f8df561-de17bf6924b74456e167ceb69e25eb20c876d5e4/index.html	https://ad-hoc-expensify-cash.s3.us-east-1.amazonaws.com/rock-artifacts/ad-hoc/rock-ios-device-AdHoc-aedd78c-f8df561-951a79479c5d0b54cfcb1e4079f7ecaac8b94b42/index.html

Web 🕸️
https://104252.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

OSBotify · 2026-10-21T20:08:30Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.16-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

MelvinBot · 2026-10-21T20:12:51Z

No help site update is needed. This PR only makes Download CSV appear for admins before any rates exist, and no help article says the option requires existing rates.

Details

The closest article is Configure Per Diem in a workspace. It says "Download CSV – Export your current Per Diem rate list." That sentence is still accurate.

view run

OSBotify · 2026-10-22T19:22:38Z

🚀 Deployed to staging by https://github.com/JS00001 in version: 9.5.18-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

MelvinBot · 2026-10-22T19:27:14Z

No help site update needed. This PR only makes Download CSV appear for admins before any Per Diem rates exist, and no sentence in Configure-Per-Diem-in-a-workspace.md says the option is hidden until rates are added, so the article is still accurate.

view run

OSBotify · 2026-10-23T16:53:46Z

🚀 Deployed to production by https://github.com/grgia in version: 9.5.18-1 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Bundle Size Analysis (Sentry):

Android
iOS

Show Per Diem Download CSV option before rates are added so admins ca…

8af1e0f

…n grab the import template Co-authored-by: Eskalifer1 <[email protected]>

MelvinBot assigned Eskalifer1 Oct 16, 2026

MelvinBot requested a review from a team October 16, 2026 15:57

melvin-bot Bot added Melvin-Test-Android Melvin-Test-Web Triggers Melvin to run the testing steps of the PR on web labels Oct 16, 2026

MelvinBot mentioned this pull request Oct 16, 2026

[Due for payment 2026-10-30] [$175] Allow the Per Diem import template to be downloaded before adding rates. #104175

Open

7 tasks done

chatgpt-codex-connector Bot reviewed Oct 16, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into claude-perDiemDownloa…

73ca0ef

…dCsvBeforeRates Co-authored-by: Eskalifer1 <[email protected]>

MelvinBot marked this pull request as ready for review October 21, 2026 10:45

MelvinBot requested a review from a team as a code owner October 21, 2026 10:45

melvin-bot Bot requested a review from Eskalifer1 October 21, 2026 10:45

melvin-bot Bot removed the request for review from a team October 21, 2026 10:45

melvin-bot Bot requested review from heyjennahay and removed request for a team October 21, 2026 10:45

This comment was marked as duplicate.

Sign in to view

Eskalifer1 approved these changes Oct 21, 2026

View reviewed changes

melvin-bot Bot requested a review from JS00001 October 21, 2026 10:53

JS00001 approved these changes Oct 21, 2026

View reviewed changes

JS00001 merged commit aedd78c into main Oct 21, 2026
50 of 53 checks passed

JS00001 deleted the claude-perDiemDownloadCsvBeforeRates branch October 21, 2026 12:47

OSBotify mentioned this pull request Oct 21, 2026

Deploy Checklist: New Expensify 2026-10-21 #104620

Closed

83 tasks done

		if (hasVisibleSubRates \|\| canWritePerDiem) {
		menuItems.push({

Conversation

MelvinBot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

Eskalifer1 commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector Bot Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

Eskalifer1 Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

MelvinBot commented Oct 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

Eskalifer1 commented Oct 16, 2026

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

MelvinBot commented Oct 16, 2026

Uh oh!

Eskalifer1 commented Oct 19, 2026

Uh oh!

MelvinBot commented Oct 19, 2026

Uh oh!

codecov Bot commented Oct 19, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Eskalifer1 commented Oct 21, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 21, 2026

Uh oh!

Eskalifer1 commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 21, 2026

Uh oh!

Eskalifer1 commented Oct 21, 2026

Reviewer Checklist

Screenshots/Videos

Uh oh!

Eskalifer1 commented Oct 21, 2026

Uh oh!

Eskalifer1 commented Oct 21, 2026

Uh oh!

MelvinBot commented Oct 16, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Oct 16, 2026 •

edited

Loading

MelvinBot commented Oct 16, 2026 •

edited

Loading

codecov Bot commented Oct 19, 2026 •

edited by github-actions Bot

Loading