Repository navigation
[No QA] Docs updates for E/A#102438 Let admins merge expenses across a member's reports - #104219
Conversation
Co-authored-by: Youssef Lourayad <[email protected]>
|
A preview of your ExpensifyHelp changes have been deployed to https://7b8d7498.helpdot.pages.dev ⚡️ Updated articles: |
|
@flaviadefaria can you mark this ready for review please? |
|
Ah, I thought you were meant to do this based on this comment in the OP:
But doing it now. |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? cc @heyjennahay |
|
@heyjennahay Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall AssessmentThis PR makes a small, targeted clarification to the "Who can merge duplicate expenses" section of the Merge Duplicate Expenses article. It splits a single bullet (covering approvers and workspace admins together) into two separate bullets: approvers can merge expenses on the same Draft or Outstanding report, while workspace admins can merge a member's expenses across that member's Draft and Outstanding reports. The change improves accuracy and also removes a trailing-whitespace issue from the original line. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: Detailed line-by-line feedback has been provided as inline comments. |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.15-1 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.15-3 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Updates the help site for [Payment due
@daledah] Allow admins to merge card + cash expenses across draft reports.That PR lets workspace admins merge a member's expenses that sit on different Draft or Outstanding reports, not only expenses on the same report. This sentence in How to Merge Duplicate Expenses is now incorrect:
This PR splits it into two bullets. Approvers are still limited to the same report. Workspace admins can merge a member's expenses across that member's Draft and Outstanding reports. Roles are lowercased per
docs/HELPSITE_NAMING_CONVENTIONS.md. The Draft and Outstanding labels matchsrc/languages/en.ts.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/678389
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: The human co-author must fill out the QA tests you ran before marking this PR as "ready for review".
// Please describe what QA needs to do to validate your changes and what areas do they need to test for regressions.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
@youssef-lr, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.