Repository navigation
Conversation
Co-authored-by: Kevin Brian Bader <[email protected]>
38 of 40 tasks
Contributor
|
@MelvinBot You can close this PR as duplicate of #104126, we will be merging #104126 so this one should be closed. |
Contributor
|
A preview of your ExpensifyHelp changes have been deployed to https://5665d080.helpdot.pages.dev ⚡️ Updated articles: |
Contributor
Author
|
I couldn't close this PR because this run doesn't have permission to close PRs. Please close it yourself as a duplicate of [No QA] Docs updates for E/A#102472 Update domain admin vacation delegate steps for new form, which will be merged instead. |
This comment has been minimized.
This comment has been minimized.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Help site update for [No QA] Add a clear after date to vacation delegates and show them on the Profile page.
That PR changed how domain admins set a vacation delegate for a domain member. Selecting Vacation delegate now opens a form. The admin selects Choose delegate, picks a member, and then selects Save. Picking a member no longer saves it right away.
These steps in
docs/articles/new-expensify/domains/Manage-Domain-Members.md(How to assign a Vacation Delegate on behalf of a Domain Member) became incorrect:The form has no Confirm button, and the member list only opens from Choose delegate. This PR changes those two steps to:
The labels come from
src/languages/en.ts(statusPage.vacationDelegate.chooseDelegate→ "Choose delegate",common.save→ "Save").@ikevin127, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying
@MelvinBot mark this PR as ready for review.Fixed Issues
$ #102202
PROPOSAL:
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari