Skip to content

[No QA] Docs updates for E/A#102472 Update domain vacation delegate steps to use Save - #104172

Closed
MelvinBot wants to merge 1 commit into
mainfrom
claude-docsDomainVacationDelegateSave
Closed

MelvinBot wants to merge 1 commit into
mainfrom
claude-docsDomainVacationDelegateSave

Conversation

@MelvinBot

Copy link
Copy Markdown
Contributor

Explanation of Change

Help site update for [No QA] Add a clear after date to vacation delegates and show them on the Profile page.

That PR changed how domain admins set a vacation delegate for a domain member. Selecting Vacation delegate now opens a form. The admin selects Choose delegate, picks a member, and then selects Save. Picking a member no longer saves it right away.

These steps in docs/articles/new-expensify/domains/Manage-Domain-Members.md (How to assign a Vacation Delegate on behalf of a Domain Member) became incorrect:

  1. Select the member you want to assign as the delegate.
  2. Click Confirm.

The form has no Confirm button, and the member list only opens from Choose delegate. This PR changes those two steps to:

  1. Select Choose delegate, then select the member you want to assign as the delegate.
  2. Select Save.

The labels come from src/languages/en.ts (statusPage.vacationDelegate.chooseDelegate → "Choose delegate", common.save → "Save").

@ikevin127, please review the files changed and confirm they reflect the current behavior. Then post a new comment saying @MelvinBot mark this PR as ready for review.

Fixed Issues

$ #102202
PROPOSAL:

Tests

// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.

  • Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified any copy / text that was added to the app is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If the PR adds or modifies the UI:
    • I asked an AI agent to review the changes for accessibility issues and addressed its findings.
    • I tested with a screen reader (VoiceOver on macOS) and verified all new/changed elements are reachable with a logical focus order.
    • I verified all new/changed elements have meaningful accessible names and roles.
    • I verified state changes are announced (e.g. checked/unchecked, expanded/collapsed, selected).
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari

@MelvinBot
MelvinBot requested a review from a team October 15, 2026 22:21
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Oct 15, 2026
@ikevin127

Copy link
Copy Markdown
Contributor

@MelvinBot You can close this PR as duplicate of #104126, we will be merging #104126 so this one should be closed.

@github-actions github-actions Bot changed the title Docs updates for E/A#102472 Update domain vacation delegate steps to use Save [No QA] Docs updates for E/A#102472 Update domain vacation delegate steps to use Save Oct 15, 2026
@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://5665d080.helpdot.pages.dev ⚡️

Updated articles:

@MelvinBot

Copy link
Copy Markdown
Contributor Author

I couldn't close this PR because this run doesn't have permission to close PRs.

Please close it yourself as a duplicate of [No QA] Docs updates for E/A#102472 Update domain admin vacation delegate steps for new form, which will be merged instead.


view run

@ikevin127

This comment has been minimized.

@ikevin127 ikevin127 closed this Oct 16, 2026
@ikevin127

Copy link
Copy Markdown
Contributor

❌ Closed as this PR as duplicate of #104126, we will be merging #104126 so this one can be closed as duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants