Repository navigation
[No QA] Update help docs for Release 1: Add pending BYOC transactions (Plaid) - #104021
Conversation
Co-authored-by: Joseph Kaufman <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
@MelvinBot as it relates to this comment, item 7 has shipped. Please update the PR accordingly. |
|
@MelvinBot please also address this comment |
… error modal Co-authored-by: Joseph Kaufman <[email protected]>
This comment has been minimized.
This comment has been minimized.
|
This is already done in ddb9045, pushed right after your comment. The "pending card transactions" FAQ in |
|
@MelvinBot I checked the submit behavior behind this FAQ. For an all-pending report, the report header can show Submit for Plaid company card transactions and then show the pending-transactions modal when selected. For pending Expensify Card transactions, the header can hide Submit because those transactions fail its eligibility check. This difference comes from transaction eligibility, not from having one expense versus multiple. The report preview also hides Submit for any all-pending report. Could you make the FAQ state the submission rule without describing button visibility? Suggested wording:
|
…on visibility Co-authored-by: Joseph Kaufman <[email protected]>
|
Done in 98eaa39. The pending card transactions FAQ in
The FAQ no longer says the report is left out of the Submit to-do. No other article in the PR describes button visibility for pending reports. |
|
@MelvinBot is this still ongoing? |
This comment has been minimized.
This comment has been minimized.
…anned receipts Co-authored-by: Joseph Kaufman <[email protected]>
|
That one had been missed, sorry. It's now done in 178dc4e. Why Expenses Duplicate now says pending Plaid card transactions can auto-merge with SmartScanned receipts. I also updated the PR description. What changed in
|
This comment has been minimized.
This comment has been minimized.
|
Changes look good to me. Opening for review. 👍 |
Product reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR? |
|
@flaviadefaria Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
HelpDot Documentation ReviewOverall Assessment This PR updates nine existing help articles (seven New Expensify, two Expensify Classic) to document that cards connected through Plaid now import pending transactions, correcting prior statements that only posted transactions import. The changes are small, consistent, and well-scoped: every edit limits the new behavior to Plaid and preserves the existing "posted only" rule for other connections. A new FAQ in Set up a Direct Connection for Company Cards acts as the single source of truth, and other articles link to it rather than duplicating the detail. This is a clean, maintainable approach. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a summary review. Scores reflect only the proposed changes in the diff. |
Clarified the connection process for bank accounts and updated wording for transaction imports.
|
Addressed review comment about using technical term |
|
🚀 Deployed to staging by https://github.com/stephanieelliott in version: 9.5.13-0 🚀
|
|
🚀 Deployed to production by https://github.com/grgia in version: 9.5.13-6 🚀
Bundle Size Analysis (Sentry): |
Explanation of Change
Cards connected through Plaid now import pending transactions. Several help articles still said only posted transactions import, so they were wrong for Plaid cards. This PR updates those articles. Other direct connections still import only posted transactions, so every change is scoped to Plaid.
isPending(), which checks onlytransaction.statusand applies to any card type.Fixed Issues
$ https://github.com/Expensify/Expensify/issues/633255
$ https://github.com/Expensify/Expensify/issues/691737
QA Steps
N/A