Skip to content

[$175] Personal card-Not able to add Mock personal card second time #104286

Open

Description

@applause-bot

If you haven’t already, check out our contributing guidelines for onboarding. To join our Slack channel, fill out this form.


Version Number: 9.5.13-1
Reproducible in staging?: Yes
Reproducible in production?: No
If this was caught during regression testing, add the test name, ID and link from BrowserStack: https://test-management.browserstack.com/tc/TC-414884
Email or phone of affected tester (no customers): N/A
Issue reported by: Applause Internal Team
Bug source: Exploratory - Significant User Experience Deterioration
Device used: MacBook Air 26.6.1 Chrome
App Component: User Settings

Action Performed:

  1. Sign up to ND with a new gmail account, selecting Something else purpose
  2. Validate the account
  3. Go to Wallet - Add personal card - US - Mock bank
  4. Click Next, click Continue on the successful screen
  5. Delete both cards
  6. Repeat steps 3-4

Expected Result:

Successful screen appears, cards are added

Actual Result:

Successful screen does not appear, Mock bank personal cards are not added second time

Workaround:

Unknown

Platforms:

  • Android: App
  • Android: mWeb Chrome
  • iOS: App
  • iOS: mWeb Safari
  • iOS: mWeb Chrome
  • Windows: Chrome
  • MacOS: Chrome Safari

Screenshots/Videos

To be added by Applause Leads

Bug7288345_1792173564255.Not_able_to_add_Mock_personal_card_second_time.mp4

View all open jobs on GitHub

Applause Internal Information
Exported by: Chandana Kiran
Bug ID: 7288345

Upwork Automation - Do Not Edit

Activity

  1. added
    DeployBlockerCashThis issue or pull request should block deployment
    BugSomething is broken. Auto assigns a BugZero manager.
    on Oct 16, 2026
  2. applause-bot commented on Oct 16, 2026

    @applause-bot
    Author

    While Applause doesn't embed attachments for this bug, here are the links for quick view:
    https://platform.applause.com/services/links/v1/external/39b47868b8b8f55d68e870626ed6ca9d279319e737c44e043e8fdda2f3827837

  3. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    Triggered auto assignment to @carlosmiceli (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

  4. github-actions commented on Oct 16, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  5. melvin-bot commented on Oct 16, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. MelvinBot commented on Oct 16, 2026

    @MelvinBot
    Contributor

    Deploy Blocker Analysis

    Result: No causing App PR found. This most likely comes from the backend running on staging (medium confidence).

    None of the App PRs in Deploy Checklist: New Expensify 2026-10-16 change the personal-card flow. Staging calls the staging API, so a backend change deployed only to staging would explain "staging: yes, production: no."

    Recommended next step: On staging web, turn off Troubleshoot → Use staging server and repeat steps 3–6.

    • If the cards add normally, the backend on staging caused it. Swap DeployBlockerCash for DeployBlocker and ask an internal engineer to check recent backend changes to personal-card import and card deletion.
    • If it still fails, the App is involved. Reply here and I'll dig further.

    Keep DeployBlockerCash on until that test is done.

    Investigation details

    How I ruled out App PRs

    I compared origin/production (5c5d8a6) with origin/staging (d710f20). There are no changes in:

    • src/pages/settings/Wallet/
    • src/libs/actions/PersonalCards.ts
    • src/libs/actions/Card.ts
    • src/libs/actions/getCompanyCardBankConnection/
    • src/libs/CardUtils.ts
    • src/hooks/useImportPersonalPlaidAccounts.ts

    No added or removed line in the diff mentions CARD_LIST, cardList, lastImportAttempt, ADD_NEW_PERSONAL_CARD, or Plaid. package.json changes only the version, so no dependency or Onyx bump.

    The PRs closest to this area don't apply:

    Why the backend is the likely cause

    The success screen appears only when a new card, or a changed lastImportAttempt, arrives in CARD_LIST from the server:

    The report says the cards aren't added at all, not just that the success screen is missing. That points to the second Mock bank import not recreating the cards after they were deleted.

    Latent App weakness (unchanged since production, not a revert candidate)

    useGetNewPersonalCard.ts:18-19 treats an empty previous cardList as "no baseline yet." After you delete every card, the first update that brings cards back becomes the baseline, so the success screen doesn't appear. If the backend now sends fewer CARD_LIST updates, this would hide the success screen even when the import works. Refreshing Wallet after the second attempt tells the two cases apart: missing cards mean the import failed; present cards mean only success detection failed.

    Reproduction attempt

    I tried to reproduce this on a local web build, but the test session never loaded, so I have no repro result.


    Next Steps: Reply with @MelvinBot <your feedback> to refine this analysis.


    view run · no recording available

  7. added and removed
    DeployBlockerCashThis issue or pull request should block deployment
    on Oct 19, 2026
  8. grgia commented on Oct 19, 2026

    @grgia
    Contributor

    Demoting from blocker, it seems there's a problem and the browser skipped opening the popup. but it's intermittent.

    Melvin's BE RCA is wrong

  9. carlosmiceli commented on Oct 22, 2026

    @carlosmiceli
    Contributor

    RCA summary

    The failure is caused by browser popup blocking. The app calls window.open() from a useEffect after navigating to the bank-connection step, rather than directly from the user’s Next click. Browsers may reject this delayed call, so the Mock Bank window never opens and no cards are added.

    This is a frontend timing issue introduced with the original personal-card flow in PR #84042, not a backend failure.

    — Carlos’s AI agent

  10. added
    ExternalAdded to denote the issue can be worked on by a contributor
    on Oct 22, 2026
  11. melvin-bot commented on Oct 22, 2026

    @melvin-bot

    Triggered auto assignment to Contributor-plus team member for initial proposal review - @daledah (External)

  12. changed the title [-]Personal card-Not able to add Mock personal card second time[/-] [+][$175] Personal card-Not able to add Mock personal card second time[/+] on Oct 22, 2026
  13. melvin-bot commented on Oct 22, 2026

    @melvin-bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

BugSomething is broken. Auto assigns a BugZero manager.DailyKSv2EngineeringExternalAdded to denote the issue can be worked on by a contributor

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions