Repository navigation
[Payment due @abzokhattab] Add the join-workspace onboarding intent and Concierge follow up tasks - #103652
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
Keep the onboarding route registered during fresh sign-in and gate only the redirect while Validate Login is focused. Allow the initial onboarding reset before the guard's onboarding NVP subscription has loaded, instead of treating missing data as completed and redirecting to Home.
|
@ChavdaSachin Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
(Sidenote: I'm kinda surprised we're adding this as an intent cause A) we should know this already right? and B) does this give us any useful information to act upon? @dylanexpensify . cc @Expensify/design ) Videos look good though 👍 |
I think @garrettmknight can explain it best. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚧 iwiznia has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
🚀 Deployed to staging by https://github.com/iwiznia in version: 9.5.9-0 🚀
|
|
Yes, the help site needs an update. This PR adds a new user-facing onboarding option, Join my company workspace, and it isn't behind a beta. I opened a draft docs PR: Docs updates for E/A#103652 Add Join my company workspace onboarding option. The draft PR changes two articles:
I checked the labels against @carlosmiceli, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR |
|
Deploy Blocker #104001 was identified to be related to this PR. |
|
Deploy Blocker #104005 was identified to be related to this PR. |
|
Deploy Blocker #104061 was identified to be related to this PR. |
|
Deploy Blocker #104062 was identified to be related to this PR. |
|
Deploy Blocker #104063 was identified to be related to this PR. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.5.9-4 🚀
Bundle Size Analysis (Sentry): |
|
🤖 Payment issue created: #104116 |
| <OnboardingHeader shouldShowBackButton={false} /> | ||
| {/* This screen normally opens onboarding, so there is nothing to go back to unless the intent list sent us here. */} | ||
| <OnboardingHeader | ||
| shouldShowBackButton={isJoiningCompanyWorkspace && !isConciergeTaskFlow} |
Explanation of Change
Adds a Join my company workspace onboarding intent. Public-email accounts add a work email, unvalidated private-domain accounts validate their email, and validated private-domain accounts see joinable workspaces.
When a user skips a step, Concierge creates the matching Add your work email, Validate your email, or Join your company's workspace task. Opening and completing a task resumes the sequence. When no workspace is available, Concierge posts an explanation instead of another task.
Depends on:
Fixed Issues
$ https://github.com/Expensify/Expensify/issues/672346
PROPOSAL:
Tests
Test 1 - Complete joining a workspace during onboarding
Screen.Recording.2026-09-17.at.10.43.36.AM.mov
Test 2 - Start from the Add your work email Concierge task
Screen.Recording.2026-09-17.at.10.45.07.AM.mov
Test 3 - Start from the Validate your email Concierge task
Screen.Recording.2026-09-17.at.10.46.26.AM.mov
Test 4 - Start from the Join your company's workspace Concierge task
Screen.Recording.2026-09-17.at.11.24.22.AM.mov
Test 5 - Validated public-email account takeover protection
Screen.Recording.2026-09-17.at.11.25.36.AM.mov
Offline tests
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionDesignlabel and/or tagged@Expensify/designmainwas merged after review, I tested again according to the Test stepsScreenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari