Skip to content

[Due for payment 2026-10-22] Onboarding - Join workspace intent stuck on workspace list when last name is empty #104038

Closed

Description

@MelvinBot

Summary

This is a deploy blocker introduced by #103652, which is on the current staging checklist.

In the new Join my company workspace onboarding flow, users who enter only a first name cannot finish onboarding. Last name is optional on the personal details step, but after a successful join the app treats it as required. The user is sent back toward personal details and stays on the workspace list, even though the join succeeded.

Steps to reproduce

  1. Create a workspace using a private-domain account.
  2. Sign up with another account on the same domain.
  3. Enter a first name and leave the optional last name blank.
  4. Select Join my company workspace.
  5. Click Join now or Ask to join once.

Expected result

Onboarding completes after joining the workspace.

Actual result

The user stays on the workspace list and onboarding does not complete, even though the join succeeded.

Fix

#104016 requires only the first name before completing onboarding and adds a regression test for an empty last name.

Found during internal QA by @carlosmiceli. Screenshots or video to follow.

Reported in Slack.

Issue OwnerCurrent Issue Owner: @abzokhattab

Activity

  1. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    You have been assigned to this deploy blocker because you recently merged this PR: #103652

  2. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    @iwiznia @abzokhattab you have been assigned to this deploy blocker because you reviewed the offending PR: #103652

  3. github-actions commented on Oct 14, 2026

    @github-actions
    Contributor

    👋 Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

    1. Identify the pull request that introduced this issue and revert it.
    2. Find someone who can quickly fix the issue.
    3. Fix the issue yourself.
  4. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    @carlosmiceli you have been assigned to this deploy blocker because you authored the offending PR: #103652

  5. melvin-bot commented on Oct 14, 2026

    @melvin-bot

    💬 A slack conversation has been started in #expensify-open-source

  6. carlosmiceli commented on Oct 14, 2026

    @carlosmiceli
    Contributor

    Fixed by CP: #104016 (comment)

  7. m-natarajan commented on Oct 15, 2026

    @m-natarajan

    Issue is not reproducible on Windows 11 / Chrome in v9.5.9-4

    bandicam.2026-10-15.15-02-34-014.mp4
  8. changed the title [-]Onboarding - Join workspace intent stuck on workspace list when last name is empty[/-] [+][Due for payment 2026-10-22] Onboarding - Join workspace intent stuck on workspace list when last name is empty[/+] on Oct 15, 2026
  9. melvin-bot commented on Oct 15, 2026

    @melvin-bot

    @abzokhattab

    The solution for this issue has been 🚀 deployed to production 🚀 in version 9.5.9-4 and is now subject to a 7-day regression period 📆. Here is the list of pull requests that resolve this issue:

    If no regressions arise, payment will be issued on 2026-10-22. 🎊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions