Repository navigation
[Merge ATS] Add Ashby specific approver field #103134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuwenmemon
merged 13 commits into
Expensify:main
from
bernhardoj:feat/103091-add-ashby-approver-field
Oct 21, 2026
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a853cf6
add ashby specific approver field
bernhardoj 6c4cccc
Merge branch 'main' into feat/103091-add-ashby-approver-field
bernhardoj bf15931
fix test
bernhardoj 0635b37
lint
bernhardoj 361ce19
add translations
bernhardoj f93cef4
update first approver subtitle
bernhardoj a878a65
update comment
bernhardoj 4617393
add translation
bernhardoj d855d2b
Merge branch 'main' into feat/103091-add-ashby-approver-field
bernhardoj cbb1ffd
don't show anything when final approver is not set
bernhardoj 5b0e1b7
add missing space
bernhardoj d2d4187
fix test
bernhardoj e4dc155
remove test
bernhardoj File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When an Ashby admin chooses Advanced approval, this flow now offers
Hiring manager, but bothapproverFieldDescriptionandapprovalModeDescriptions.advancedstill say that only a recruiter or coordinator can become the approver. This makes the new valid choice look contradictory or unsupported; make those descriptions provider-aware (or otherwise include the hiring-manager case for Ashby) while preserving Greenhouse's two-field wording.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuwenmemon currently the First approver subtitle says "either their Recruiter or their Coordinator". What should it say for Ashby?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Ashby, I'd say "Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinator in Ashby."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yuwenmemon since there will be more ATS added later, do you think it's better to have a common message for them all?
If there are only 2 options (like Greenhouse does), then they will be separated by
oronly.Choose the first approver for your candidates: their recruiter or recruiting coordinatorIf there are more than 2, then it will be separated by
,andorat the end.Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinatorUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bernhardoj’s suggestion looks fine to me but I think it would also be fine to keep the old description when there are 2 options:
Choose the first approver for your candidates: either their Recruiter or their Coordinator assigned in Greenhouse.When there are 3 options, @yuwenmemon’s suggestion looks perfect:
Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinator assigned in Ashby.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I applied @DylanDylann suggestion. @yuwenmemon if that looks good, please run the translation script once again.