Repository navigation
[Merge ATS] Add Ashby specific approver field - #103134
Merged
yuwenmemon merged 13 commits intoOct 21, 2026
Merged
Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx bun ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
bernhardoj
marked this pull request as ready for review
October 17, 2026 14:21
melvin-bot
Bot
requested review from
dylanexpensify and
getusha
and removed request for
a team
October 17, 2026 14:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0635b37537
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| }, | ||
| approverFields: { | ||
| recruiter: 'Recruiter', | ||
| hiringManager: 'Hiring manager', |
There was a problem hiding this comment.
When an Ashby admin chooses Advanced approval, this flow now offers Hiring manager, but both approverFieldDescription and approvalModeDescriptions.advanced still say that only a recruiter or coordinator can become the approver. This makes the new valid choice look contradictory or unsupported; make those descriptions provider-aware (or otherwise include the hiring-manager case for Ashby) while preserving Greenhouse's two-field wording.
Useful? React with 👍 / 👎.
Contributor
Author
There was a problem hiding this comment.
@yuwenmemon currently the First approver subtitle says "either their Recruiter or their Coordinator". What should it say for Ashby?
Contributor
There was a problem hiding this comment.
For Ashby, I'd say "Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinator in Ashby."
Contributor
Author
There was a problem hiding this comment.
@yuwenmemon since there will be more ATS added later, do you think it's better to have a common message for them all?
If there are only 2 options (like Greenhouse does), then they will be separated by or only.
Choose the first approver for your candidates: their recruiter or recruiting coordinator
If there are more than 2, then it will be separated by , and or at the end.
Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinator
Contributor
There was a problem hiding this comment.
@bernhardoj’s suggestion looks fine to me but I think it would also be fine to keep the old description when there are 2 options:
Choose the first approver for your candidates: either their Recruiter or their Coordinator assigned in Greenhouse.
When there are 3 options, @yuwenmemon’s suggestion looks perfect:
Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinator assigned in Ashby.
Contributor
Author
There was a problem hiding this comment.
I applied @DylanDylann suggestion. @yuwenmemon if that looks good, please run the translation script once again.
This comment has been minimized.
This comment has been minimized.
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
DylanDylann
reviewed
Oct 19, 2026
| }, | ||
| approverFields: { | ||
| recruiter: 'Recruiter', | ||
| hiringManager: 'Hiring manager', |
Contributor
There was a problem hiding this comment.
@bernhardoj’s suggestion looks fine to me but I think it would also be fine to keep the old description when there are 2 options:
Choose the first approver for your candidates: either their Recruiter or their Coordinator assigned in Greenhouse.
When there are 3 options, @yuwenmemon’s suggestion looks perfect:
Choose the first approver for your candidates: their recruiter, hiring manager, or recruiting coordinator assigned in Ashby.
Contributor
|
@bernhardoj Overall, it looks good. Please ping me after you've updated the description text on the First Approver page. |
Contributor
Author
|
@DylanDylann updated the description text |
dylanexpensify
previously approved these changes
Oct 19, 2026
dylanexpensify
left a comment
dylanexpensify
left a comment
Contributor
There was a problem hiding this comment.
Looks good from a product perspective 👍
Contributor
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: View the translation diffdiff --git a/src/languages/de.ts b/src/languages/de.ts
index c1728a1b..28d4ec3f 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -9037,7 +9037,7 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
dontSeeYourATS: `<muted-text-label>Sie sehen Ihr ATS hier nicht? <a href="#">Fragen Sie Concierge</a>, und wir können es hinzufügen.</muted-text-label>`,
importSettings: 'Import-Einstellungen',
defaultApprover: 'Standardgenehmiger',
- approverFields: {recruiter: 'Personalvermittler', recruitingCoordinator: 'Recruiting-Koordinator', hiringManager: 'Einstellende Führungskraft'},
+ approverFields: {recruiter: 'Personalvermittler', recruitingCoordinator: 'Recruiting-Koordinator', hiringManager: 'Einstellungsmanager'},
filters: {
description: (providerName: string) => `Wählen Sie aus, welche Mitglieder aus ${providerName} importiert werden. Sie können nach Jobphasen, Tags und Büros auswählen.`,
stages: {
@@ -9071,8 +9071,12 @@ Fügen Sie weitere Ausgabelimits hinzu, um den Cashflow Ihres Unternehmens zu sc
finalApprover: `Endgültige genehmigende Person`,
finalApproverOptional: 'Endgültige Freigabe (optional)',
approvalModeDescription: (providerName: string) => `Legen Sie die genehmigende Person für neue Mitglieder fest, die von ${providerName} nach Expensify importiert werden.`,
- approverFieldDescription: (providerName: string) =>
- `Wählen Sie die erste approver:ent für Ihre Kandidat:innen: entweder ihre:n Recruiter:in oder ihre:n Koordinator:in, die bzw. der in ${providerName} zugewiesen ist.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `ihre*n ${fieldNames.slice(0, -1).join(', ')} oder ${lastFieldName}` : `entweder ihre ${fieldNames.join('oder deren')}`;
+ return `Wählen Sie die erste genehmigende Person für Ihre Kandidat:innen: ${fieldList}, zugewiesen in ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Wählen Sie eine einzelne genehmigende Person',
advanced: `Die Personalvermittlerin/der Personalvermittler oder die Koordinatorin/der Koordinator der Kandidatin/des Kandidaten wird zur Genehmigerin/zum Genehmiger ihrer Spesen`,
diff --git a/src/languages/el.ts b/src/languages/el.ts
index a05ae477..78113fb3 100644
--- a/src/languages/el.ts
+++ b/src/languages/el.ts
@@ -7982,8 +7982,12 @@ _Για πιο αναλυτικές οδηγίες, [επισκεφθείτε τ
finalApprover: `Τελική έγκριση`,
finalApproverOptional: 'Τελικός εγκρίτης (προαιρετικό)',
approvalModeDescription: (providerName: string) => `Ορίστε τον εγκριτή για τα νέα μέλη που εισάγονται από το ${providerName} στο Expensify.`,
- approverFieldDescription: (providerName: string) =>
- `Επιλέξτε τον πρώτο εγκρίνοντα για τους υποψηφίους σας: είτε τον υπεύθυνο προσλήψεών τους είτε τον συντονιστή τους που έχει οριστεί στο ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `το ${fieldNames.slice(0, -1).join(', ')} τους ή το ${lastFieldName} τους` : `είτε ο/η ${fieldNames.join('ή την/τον/τα')} τους`;
+ return `Επιλέξτε τον πρώτο εγκριτή για τους υποψηφίους σας: ${fieldList} που έχουν ανατεθεί στο ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Επιλέξτε έναν μόνο εγκρίνοντα',
advanced: `Ο υπεύθυνος προσλήψεων ή ο συντονιστής της υποψηφιότητας γίνεται εγκρίνων των εξόδων τους`,
diff --git a/src/languages/es.ts b/src/languages/es.ts
index c5aaf863..781379b8 100644
--- a/src/languages/es.ts
+++ b/src/languages/es.ts
@@ -7711,7 +7711,12 @@ El plan Controlar empieza en 9 $ por miembro activo al mes.`,
finalApprover: `Aprobador final`,
finalApproverOptional: 'Aprobador final (opcional)',
approvalModeDescription: (providerName: string) => `Establece el aprobador para los nuevos miembros que se importen desde ${providerName} a Expensify.`,
- approverFieldDescription: (providerName: string) => `Elige el primer aprobador para tus candidatos: puede ser su reclutador o su coordinador asignado en ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `su ${fieldNames.slice(0, -1).join(', ')}, o ${lastFieldName}` : `ya sea su ${fieldNames.join('o su')}`;
+ return `Elige al primer aprobador para tus candidatos: ${fieldList} asignado en ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Elige un único aprobador',
advanced: `El reclutador o coordinador del candidato se convierte en su aprobador de gastos`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index e710558d..bf24359e 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -9091,8 +9091,12 @@ Ajoutez davantage de règles de dépenses pour protéger la trésorerie de l’e
finalApprover: `Approbateur final`,
finalApproverOptional: 'Approbateur final (facultatif)',
approvalModeDescription: (providerName: string) => `Définissez l’approbateur pour les nouveaux membres importés de ${providerName} vers Expensify.`,
- approverFieldDescription: (providerName: string) =>
- `Choisissez le premier approbateur pour vos candidat·es : soit leur recruteur·se, soit leur coordinateur·rice assigné·e dans ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `leur ${fieldNames.slice(0, -1).join(', ')}, ou leur ${lastFieldName}` : `soit leur ${fieldNames.join('ou leur')}`;
+ return `Choisissez le premier approbateur pour vos candidats : ${fieldList} assigné dans ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Choisir un seul approbateur',
advanced: `Le recruteur ou le coordinateur du candidat devient la personne qui approuve ses dépenses`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 403707a8..44d622c2 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -8980,7 +8980,7 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
dontSeeYourATS: `<muted-text-label>Non vedi il tuo ATS qui? <a href="#">Chiedi a Concierge</a> e possiamo aggiungerlo.</muted-text-label>`,
importSettings: 'Impostazioni di importazione',
defaultApprover: 'Approvatore predefinito',
- approverFields: {recruiter: 'Recruiter', recruitingCoordinator: 'Coordinatore recruiting', hiringManager: 'Responsabile assunzioni'},
+ approverFields: {recruiter: 'Recruiter', recruitingCoordinator: 'Coordinatore recruiting', hiringManager: 'Responsabile delle assunzioni'},
filters: {
description: (providerName: string) => `Seleziona quali membri importare da ${providerName}. Puoi scegliere in base alle fasi lavorative, ai tag e alle sedi.`,
stages: {
@@ -9014,8 +9014,12 @@ Aggiungi altre regole di spesa per proteggere il flusso di cassa aziendale.`,
finalApprover: `Approvatore finale`,
finalApproverOptional: 'Approvatore finale (facoltativo)',
approvalModeDescription: (providerName: string) => `Imposta il responsabile delle approvazioni per i nuovi membri importati da ${providerName} in Expensify.`,
- approverFieldDescription: (providerName: string) =>
- `Scegli il primo approvatore per i tuoi candidati: il loro Recruiter oppure il loro Coordinator assegnato in ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `il loro ${fieldNames.slice(0, -1).join(', ')} o ${lastFieldName}` : `o il loro ${fieldNames.join('o il loro')}`;
+ return `Scegli il primo approvatore per i tuoi candidati: ${fieldList} assegnato in ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Scegli un solo approvatore',
advanced: `Il recruiter o il coordinatore del candidato diventa il suo approvatore di spese`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 8428f9bc..3605467a 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -8895,8 +8895,12 @@ ${reportName}`,
finalApprover: `最終承認者`,
finalApproverOptional: '最終承認者（任意）',
approvalModeDescription: (providerName: string) => `${providerName} から Expensify にインポートされる新しいメンバーの承認者を設定します。`,
- approverFieldDescription: (providerName: string) =>
- `候補者の最初の承認者を選択します。${providerName} で割り当てられているリクルーターまたはコーディネーターのいずれかを指定してください。`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `${fieldNames.slice(0, -1).join(', ')} または ${lastFieldName}` : `または ${fieldNames.join('またはその')} のいずれか`;
+ return `候補者の最初の承認者を選択してください：${providerName} で割り当てられている ${fieldList}`;
+ },
approvalModeDescriptions: {
basic: '承認者を 1 名選択してください',
advanced: `候補者のリクルーターまたはコーディネーターが、その候補者の経費承認者になります`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index cf247a94..daf9d4a8 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -8992,7 +8992,12 @@ er bestedingsregels toe om de kasstroom van het bedrijf te beschermen.`,
finalApprover: `Laatste goedkeurder`,
finalApproverOptional: 'Laatste fiatteur (optioneel)',
approvalModeDescription: (providerName: string) => `Stel de fiatteur in voor nieuwe leden die vanuit ${providerName} in Expensify worden geïmporteerd.`,
- approverFieldDescription: (providerName: string) => `Kies de eerste fiatteur voor je kandidaten: ofwel hun recruiter of hun coördinator die is toegewezen in ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `hun ${fieldNames.slice(0, -1).join(', ')}, of ${lastFieldName}` : `hun ${fieldNames.join('of hun')}`;
+ return `Kies de eerste fiatteur voor je kandidaten: ${fieldList} toegewezen in ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Kies één fiatteur',
advanced: `Recruiter of coördinator van de kandidaat wordt zijn/haar onkostengoedkeurder`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index b5e37be9..8a7d7552 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -9008,7 +9008,12 @@ Dodaj więcej zasad wydatków, żeby chronić płynność finansową firmy.`,
finalApprover: `Ostateczny akceptujący`,
finalApproverOptional: 'Ostateczny zatwierdzający (opcjonalnie)',
approvalModeDescription: (providerName: string) => `Ustaw osobę zatwierdzającą dla nowych członków importowanych z ${providerName} do Expensify.`,
- approverFieldDescription: (providerName: string) => `Wybierz pierwszą osobę akceptującą dla swoich kandydatów: Rekrutera lub Koordynatora przypisanego w ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `ich ${fieldNames.slice(0, -1).join(', ')} lub ${lastFieldName}` : `albo ich ${fieldNames.join('lub ich')}`;
+ return `Wybierz pierwszą osobę zatwierdzającą dla swoich kandydatów: ${fieldList} przypisane w ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Wybierz jedną osobę zatwierdzającą',
advanced: `Rekruter lub koordynator kandydata zostaje jego akceptującym wydatki`,
diff --git a/src/languages/pt-BR.ts b/src/languages/pt-BR.ts
index 9e3ea706..fabe4e5a 100644
--- a/src/languages/pt-BR.ts
+++ b/src/languages/pt-BR.ts
@@ -8995,7 +8995,12 @@ Adicione mais regras de gasto para proteger o fluxo de caixa da empresa.`,
finalApprover: `Aprovador final`,
finalApproverOptional: 'Aprovador final (opcional)',
approvalModeDescription: (providerName: string) => `Defina o aprovador para novos membros importados de ${providerName} para o Expensify.`,
- approverFieldDescription: (providerName: string) => `Escolha o primeiro aprovador para seus candidatos: o recrutador ou o coordenador atribuídos a eles em ${providerName}.`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `seu(s) ${fieldNames.slice(0, -1).join(', ')} ou ${lastFieldName}` : `ou sua ${fieldNames.join('ou de seus')}`;
+ return `Escolha o primeiro aprovador para seus candidatos: ${fieldList} atribuídos em ${providerName}.`;
+ },
approvalModeDescriptions: {
basic: 'Escolha um único aprovador',
advanced: `O recrutador ou coordenador da pessoa candidata se torna o aprovador de despesas dela`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 9d7454b2..55f50e85 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -8663,7 +8663,12 @@ ${reportName}`,
finalApprover: `最终审批人`,
finalApproverOptional: '最终审批人（可选）',
approvalModeDescription: (providerName: string) => `为从 ${providerName} 导入到 Expensify 的新成员设置审批人。`,
- approverFieldDescription: (providerName: string) => `为候选人选择第一位审批人：可以是他们在 ${providerName} 中指定的招聘人员或协调员。`,
+ approverFieldDescription: (providerName: string, approverFields: string[]) => {
+ const fieldNames = approverFields.map((approverField) => approverField.toLowerCase());
+ const lastFieldName = fieldNames.at(-1) ?? '';
+ const fieldList = fieldNames.length > 2 ? `其 ${fieldNames.slice(0, -1).join(', ')} 或 ${lastFieldName}` : `其 ${fieldNames.join('或其')}`;
+ return `为您的候选人选择第一位审批人：在 ${providerName} 中分配的 ${fieldList}。`;
+ },
approvalModeDescriptions: {basic: '选择单个审批人', advanced: `候选人的招聘人员或协调人将成为其报销审批人`, custom: '在 Expensify 中手动设置审批人'},
},
merge: {
Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2026-10-20.at.13.25.54.movAndroid: mWeb ChromeScreen.Recording.2026-10-20.at.13.19.26.moviOS: HybridAppScreen.Recording.2026-10-20.at.13.24.22.moviOS: mWeb SafariScreen.Recording.2026-10-20.at.13.17.39.movMacOS: Chrome / SafariScreen.Recording.2026-10-20.at.13.00.51.mov |
DylanDylann
approved these changes
Oct 20, 2026
DylanDylann
left a comment
DylanDylann
left a comment
Contributor
There was a problem hiding this comment.
One NIT: #103134 (comment)
But it looks unrelated to this change, so we can handle it in next PRs
Contributor
Author
|
@yuwenmemon @Expensify/design can you guys check this |
Contributor
|
Hmm I'm actually not sure - is it required to set the final approver? If so, maybe it should say Not set but also have some kind of error state? Let's see what @yuwenmemon thinks. |
Contributor
|
The final approver is optional for Advanced approval, so "Not set" shouldn't be treated as an error. I agree we should omit it from the summary when none is selected and show just "Advanced approval – Recruiter" (or whichever first-approver role was chosen). |
Contributor
Author
|
Done |
yuwenmemon
previously approved these changes
Oct 21, 2026
Contributor
|
LGTM but tests are failing! |
Contributor
|
@bernhardoj can you fix the failed test? |
DylanDylann
reviewed
Oct 21, 2026
| field: 'finalApprover', | ||
| description: translate('workspace.merge.finalApprover'), | ||
| title: getMergeFinalApproverDisplayName(mergeConfig?.finalApprover, policyEmployeePersonalDetails, translate, formatPhoneNumber), | ||
| title: getMergeFinalApproverDisplayName(mergeConfig?.finalApprover, policyEmployeePersonalDetails, translate, formatPhoneNumber) ?? translate('workspace.merge.notSet'), |
Contributor
There was a problem hiding this comment.
@bernhardoj Why do we need to fallback to NotSet here?
Contributor
Author
There was a problem hiding this comment.
It's for the HR card
Contributor
Author
|
Test fixed |
DylanDylann
approved these changes
Oct 21, 2026
yuwenmemon
approved these changes
Oct 21, 2026
Contributor
|
🚧 yuwenmemon has triggered a test Expensify/App build. You can view the workflow run here. |
Contributor
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
48 of 86 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/yuwenmemon in version: 9.5.16-0 🚀
|
|
@bernhardoj Can you please share credentials for Ashby recruiting integrations? |
Contributor
Author
|
@m-natarajan shared in Slack DM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Fixed Issues
$ #103091
PROPOSAL:
Tests
Same as QA Steps
Offline tests
Same as QA Steps
QA Steps
Prerequisite: have workspaces that are connected to Greenhouse and Ashby recruiting integrations
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
eb.mp4